Remove font_assets dependency #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSturmfels
force-pushed
the
font-assets
branch
from
fbe7ae3 to
631f4d2
Compare
|
Did you see any places where the fonts were broken on prod? |
|
Unfortunately prod isn't working for me at all due to #1046 so I can't confirm whether fonts are affected. |
From houdiniproject#524, based on the assumption that it's better to potentially break fonts than for the application not to start up.
BenSturmfels
force-pushed
the
font-assets
branch
from
631f4d2 to
9ae9b5d
Compare
|
@wwahammy now that I have
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion in #524. May potentially break fonts, but is more important that the application can start up in production mode.