Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temporary elements disappearing on subsequent GET requests that redirect to a page with data-turbo-temporary elements. #1302

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Fix temporary elements disappearing on subsequent GET requests that redirect to a page with data-turbo-temporary elements. #1302

merged 3 commits into from
Aug 26, 2024

Conversation

mikepayready
Copy link
Contributor

Fixes #1301

@mikepayready
Fix temporary elements disappearing on subsequent GET requests that r…
c403c25 
…edirect to a page with data-turbo-temporary elements.
brunoprietog
brunoprietog requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@brunoprietog brunoprietog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. In order not to introduce a regression, we should incorporate the bifurcation here as well.

brunoprietog
brunoprietog approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@brunoprietog brunoprietog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikepayready!

@brunoprietog brunoprietog merged commit 2f7abac into hotwired:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoprietog brunoprietog brunoprietog approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporary elements are removed after subsequent visits of a GET redirect
2 participants
@mikepayready @brunoprietog