Include CSRF <meta> elements in frame layout
#697
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a more conservative, less disruptive alternative to #534. While this might resolve any CSRF-related inconsistencies in the While #534 might feel too ambitious of a proposal, it circumvents this entire class of issue, and removes any burden of responsibility to decide which |
|
Regarding the failing Rails 7.1 tests, I had the same issue in another branch and submitted #696 to address them. |
Closes [hotwired#669][] If a response to a request with the `Turbo-Frame:` header does not include the `<meta>` elements in the `<html>` document, it's likely that the browser will remove any `<meta>` element present after handling navigating the `<turbo-frame>` that originated the request. In support of testing this behavior, this commit enables CSRF protection in the test suite.
seanpdoyle
force-pushed
the
closes-669
branch
from
c91825c
to
7f93935
Compare
|
@jorgemanrubia @brunoprietog are either of you experiencing this issue in your applications? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #669
If a response to a request with the
Turbo-Frame:header does not include the<meta>elements in the<html>document, it's likely that the browser will remove any<meta>element present after handling navigating the<turbo-frame>that originated the request.In support of testing this behavior, this commit enables CSRF protection in the test suite.