Support broadcast_remove_to with options #642
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
broadcast_remove_to
behavior consistent with otherbroadcast_*_to
methods by allowing keyword arguments to be passed down tobroadcast_action_to
.The main use case is supporting multiple targets for broadcast_remove_to like other methods do.
i.e.:
broadcast_remove_to *streamables, target: nil, targets: '.css-class-name'
Options are supported by the method called downstream:
broadcastable.rb
broadcasts.rb
Here are some existing examples of other
broadcast_*_to
methods following similar patterns to the change made:broadcast_update_to:
broadcast_replace_to: