Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Turbo::IncludesHelper #531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated Turbo::IncludesHelper #531

wants to merge 1 commit into from

Conversation

brunoprietog
Copy link
Contributor

Since we are updating to the next major version, we could remove the Turbo::IncludesHelper deprecated helper.

jorgemanrubia
jorgemanrubia approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @brunoprietog. Ok to merge this one @afcapel?

@afcapel
Copy link
Contributor

afcapel commented Feb 7, 2024 •
edited
Loading

Makes sense, although we had some bad luck with the timing. I just cut the v2 version a few seconds before :/

@brunoprietog
Copy link
Contributor Author

Yeah, tough luck haha. Will it work for a fast 2.0.1 version? Or will we have to wait for 3.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemanrubia jorgemanrubia jorgemanrubia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunoprietog @afcapel @jorgemanrubia