Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Turbo, Stimulus and Strada #26

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

afcapel
Copy link
Contributor

@afcapel afcapel commented Sep 8, 2023

Turbo and Stimulus are imported with importmaps, since they are already published in npm.com and available in CDNs.

Strada is vendored because it's still private. I took the vendored file from this branch hotwired/strada-web#8

@afcapel afcapel requested a review from jayohms September 8, 2023 12:52
afcapel and others added 2 commits September 8, 2023 13:59
We are now including them via importmaps.

The package.json file is now only used to run the dev server.
@jayohms jayohms merged commit 3460ecf into strada-sample Sep 8, 2023
@jayohms jayohms deleted the strada-sample-js-imports branch September 8, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants