This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
#8 - Allow users to favorite articles #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we'd need to use turbo streams if we wanted both buttons to update at the same time -- frames can only update content within its own fame (or a single other one with the |
|
I agree, I think streams might be the way to go here, however, they work on |
luanfonceca
force-pushed
the
article-favorite
branch
from
a2c775b
to
1416a9e
Compare
blopker
reviewed
Jan 12, 2021
| @@ -55,3 +63,32 @@ def form_valid(self, form): | |||
| """ | |||
| self.object = form.save(self.request.user) | |||
| return HttpResponseRedirect(self.get_success_url(), status=303) | |||
|
|
|||
|
|
|||
| class FavoriteArticle(IsAuthenticatedOrReadOnly, UpdateView): | |||
There was a problem hiding this comment.
Did you see the LoginRequiredMixin? I will redirect the user back to the right page after they login.
|
Where did this PR land? Did we figure out how to get all the buttons to toggle? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
I don't know why yet, but the turbo-frames are not being updated with eachother. When I favorite a article, only the first turbo-frame gets updated, which make sense but I couldn't find anything on the docs to make both turbo-frames work.
Context: #8
Description:
_favorite.htmlFavoriteArticleto handle favorite/unfavorite articles with annotatedfavorited_by__countScreenshots:
