Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: support to use i18n from dxp and removed app level configuration of i18n(dxp/280) #210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Mar 21, 2024

Related Issues

hotwax/dxp-components#280

Short Description and Why It's Useful

Using i18n configuration from the dxp package will help in having a common place to manage configurations related to internationalization

  • Removed i18n package from the app

  • Updated all the components and ts file to use translate method from dxp

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@R-Sourabh R-Sourabh changed the title Implemented: support to use i18n from dxp and removed app level confi… Implemented: support to use i18n from dxp and removed app level configuration of i18n(dxp/280) Mar 22, 2024
@R-Sourabh R-Sourabh requested a review from ymaheshwari1 July 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant