Skip to content

Commit

Permalink
Merge pull request #155 from sanskar345/picking/#146
Browse files Browse the repository at this point in the history
Implemented: Replaced the usage of Image component with ShopifyImg component wherever the image is fetched from Shopify
  • Loading branch information
ravilodhi authored Aug 24, 2023
2 parents 490c8bc + 8f99f2a commit a44e81d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/components/Picklist-detail-item.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<ion-item :id="picklistItem.id" :class="picklistItem.id === lastScannedId ? 'scanned-item' : '' " :key="picklistItem.id" v-for="picklistItem in picklistItems" @click="picklistItem.isChecked = !picklistItem.isChecked" lines="none" >
<ion-thumbnail slot="start">
<Image :src="getProduct(picklistItem.productId).mainImageUrl" />
<ShopifyImg :src="getProduct(picklistItem.productId).mainImageUrl" size="small" />
</ion-thumbnail>
<ion-label>
<p class="caption">{{ getProduct(picklistItem.productId).parentProductName}}</p>
Expand All @@ -18,16 +18,16 @@
import { IonCheckbox, IonItem, IonLabel, IonThumbnail } from '@ionic/vue';
import { defineComponent } from 'vue';
import { mapGetters, useStore } from 'vuex';
import Image from '@/components/Image.vue'
import { ShopifyImg } from '@hotwax/dxp-components';
export default defineComponent({
name: 'PicklistDetailItem',
components: {
Image,
IonCheckbox,
IonItem,
IonLabel,
IonThumbnail
IonThumbnail,
ShopifyImg
},
props: ['picklistItems', 'lastScannedId'],
computed: {
Expand Down
1 change: 1 addition & 0 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ const app = createApp(App)
.use(i18n)
.use(store)
.use(dxpComponents, {
defaultImgUrl: require("@/assets/images/defaultImage.png"),
login,
logout,
loader,
Expand Down

0 comments on commit a44e81d

Please sign in to comment.