Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Added inventory filter option for Shipment threshold check(#260) #276

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Oct 22, 2024

Related Issues

#260

Short Description and Why It's Useful

  • Added inventory filter option for Shipment threshold check in the BrokeringQuery view.

Screenshots of Visual Changes before/after (If There Are Any)

image

Contribution and Currently Important Rules Acceptance

@R-Sourabh R-Sourabh marked this pull request as ready for review October 22, 2024 11:07
@@ -288,6 +288,10 @@
{{ translate("Turn of the facility order limit check") }}
</ion-toggle>
</ion-item>
<ion-item v-if="getFilterValue(inventoryRuleFilterOptions, conditionFilterEnums, 'SHIP_THREHOLD')">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ion-item v-if="getFilterValue(inventoryRuleFilterOptions, conditionFilterEnums, 'SHIP_THREHOLD')">
<ion-item v-if="getFilterValue(inventoryRuleFilterOptions, conditionFilterEnums, 'SHIP_THRESHOLD')">

@ymaheshwari1 ymaheshwari1 merged commit 460da57 into hotwax:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants