Improved: condition to make the value of partial allocation updated on server when selecting promise date and also enabled partial group allocation when partial allocation is enabled(#257) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r server when selecting promise date and also enabled partial group allocation when partial allocation is enabled(hotwax#257)
… from available filter is selected(hotwax#257) When applying partial group item allocation filter, empty state from the rule filters card is removed even when no filter is displayed inside the filter card, thus added check to not honor partial group item allocation as a filter when checking condition for displaying empty state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#257
Short Description and Why It's Useful
On selecting promise date, the partial allocation and partial allocation group items being enabled, but when removing promise date filter the allocation are not removed.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance