Added the service to generate the feed file #3

Shinde-nutan · 2024-12-04T05:07:58Z

Added a service to generate the orders feed for Netsuite order sync
TODO: add details here

…cate item map for discount

…e to fetch the eligible order ids from the view and itr for each order and prepare OrderDataMap And added system message type and system message type parameter

….com/Shinde-nutan/mantle-net-suite-connector into serivce-to-prepare-create-order-feed

service/co/hotwax/netsuite/CreateOrderService.xml

dt2patel · 2024-12-04T05:18:05Z

service/co/hotwax/netsuite/CreateOrderService.xml

+                <description>The System Message Type ID for generating the Brokered Order Items Feed.</description>
+            </parameter>
+            <parameter name="systemMessageRemoteId" required="true">
+                <description>The System Message Remote Id for generating the Brokered Order Items Feed.</description>


brokered feed?

updated the description.

service/co/hotwax/netsuite/CreateOrderService.xml

dt2patel · 2024-12-04T05:22:10Z

service/co/hotwax/netsuite/CreateOrderService.xml

+        </in-parameters>
+        <actions>
+            <set field="nowDate" from="ec.user.nowTimestamp"/>
+            <log message="Generating Create Orders Feed file of HotWax for Order ${orderId} at time ${nowDate}"/>


Suggested change

<log message="Generating Create Orders Feed file of HotWax for Order ${orderId} at time ${nowDate}"/>

<log message="Generating Order Feed file for order ${orderId} at time ${nowDate}"/>

dt2patel · 2024-12-04T05:22:53Z

service/co/hotwax/netsuite/CreateOrderService.xml

+                try (ordersItr = netsuiteOrders_find.iterator()) {
+            </script>
+
+            <!-- If no orders in BrokeredOrderItemsSyncQueue, then don't generate the file -->


Suggested change





Brokered reference again

…nd file on sftp location.

Added a build.gradle file in the component.

data/ServiceJobData.xml

…ing method in the generate#CreateOrderFeed.

view instead of OrderAdjustment entity

dt2patel

Added some comments

dt2patel · 2024-12-31T00:54:45Z

data/SystemMessageData.xml

+    <moqui.service.message.SystemMessageTypeParameter systemMessageTypeId="NetSuiteOrderItemsFeed"
+        parameterName="resourcePath" parameterValue="" systemMessageRemoteId=""/>
+
+    <moqui.service.message.SystemMessageTypeParameter systemMessageTypeId="NetSuiteOrderItemsFeed"


what are these lines? seems duplicate.

Yes, sir will remove this.

dt2patel · 2024-12-31T00:55:28Z

data/SystemMessageData.xml

+        parentTypeId="LocalFeedFile"
+        sendPath=""
+        sendServiceName="co.hotwax.ofbiz.SystemMessageServices.send#SystemMessageFileSftp"
+        receivePath="${contentRoot}/CreateOrderFeed/createOrderFeed-${dateTime}.csv"/>


why is this set in the receive path? aren't we sending this feed? shouldn't it be in the send path?

dt2patel · 2024-12-31T00:58:17Z

service/co/hotwax/netsuite/CreateOrderService.xml

+            <set field="csvFilePath" from="ec.resource.getLocationReference(csvFilePathRef).getUri().getPath()"/>
+
+            <!--TODO: Here currently the view used to get the eligible orders for the create feed does not have the shipment method
+                need to figure out how we can put the checks for include and exclude shipment method.


is this still pending?

No sir, Forgot to update the comment after updating the logic,
will update the comments

dt2patel · 2024-12-31T01:08:58Z

service/co/hotwax/netsuite/CreateOrderService.xml

+            </entity-find>
+
+            <!-- Initialize total amount for non-refunded gift cards -->
+            <set field="totalNonRefundedGiftCardAmount" type="Integer"/>


I think we generally follow this pattern in OFBiz, for example "getValidInventory"

Suggested change

<set field="totalNonRefundedGiftCardAmount" type="Integer"/>

<set field="totalValidGiftCardAmount" type="Integer"/>

dt2patel · 2024-12-31T01:18:36Z

service/co/hotwax/netsuite/CreateOrderService.xml

+            <!-- Logic to sum non-refunded gift card payments -->
+            <script><![CDATA[
+                def manualRefSet = new HashSet()
+                def refundedSet = new HashSet()


this seems like an odd approach, very brut force. Can we take an approach where we think of this like a logical SQL and implement it as a dynamic view? That way we can get data in a simple query from the DB rather than computing it ourselves here.

dt2patel · 2024-12-31T01:20:11Z

service/co/hotwax/netsuite/CreateOrderService.xml

+              It can be changed in the future to reflect different tax codes as needed.
+            - For Digital Goods, the tax code is sent as "-Not Taxable-" to NetSuite.(in some cases vary based on the )
+              The current hardcoded "AVATAX" may not be suitable for all product types.
+            - We can create the record in integration type mapping based on the product types.


We should code this with the expectation that there will be an integration type mapping available for "Default NetSuite Tax Code"

Please make sample data in test environment on OMS side and then update code here so that it's not hardcoded.

Sure sir, will make the sample data, and update the logic.

Created the sample data for this:

<Enumeration enumCode="NETSUITE_TAX_CODE" enumId="NETSUITE_TAX_CODE" enumName="Netsuite Tax codes" enumTypeId="NETSUITE" discription="tax codes mapping between HotWax and Netsuite"/> <IntegrationTypeMapping integrationTypeId="NETSUITE_TAX_CODE" mappingKey="DIGITAL_GOOD" mappingValue="-Not Taxable-" description="Tax code for digital goods" /> <IntegrationTypeMapping integrationTypeId="NETSUITE_TAX_CODE" mappingKey="GIFT_CARD" mappingValue="-Not Taxable-" description="Tax code for gift cards" /> <IntegrationTypeMapping integrationTypeId="NETSUITE_TAX_CODE" mappingKey="DEFAULT" mappingValue="AVATAX" description="Fallback tax code for unmapped product types" />```

nutan shinde added 5 commits December 4, 2024 10:36

Added the service to generate the feed file

823764f

UPdated the service logic to preapre the HC gift card total and dupli…

1bbd388

…cate item map for discount

updated the service: 1. service to prepare the OrderDataMap 2. servic…

e8ff1c0

…e to fetch the eligible order ids from the view and itr for each order and prepare OrderDataMap And added system message type and system message type parameter

updated the service: 1. service to prepare the OrderDataMap 2. servic…

7239301

…e to fetch the eligible order ids from the view and itr for each order and prepare OrderDataMap And added system message type and system message type parameter

Merge branch 'serivce-to-prepare-create-order-feed' of https://github…

73d0d76

….com/Shinde-nutan/mantle-net-suite-connector into serivce-to-prepare-create-order-feed

dt2patel requested changes Dec 5, 2024

View reviewed changes

Added the groovy script and logic to convert the json into csv and se…

1212edf

…nd file on sftp location.

Shinde-nutan marked this pull request as draft December 11, 2024 14:59

Shinde-nutan added 3 commits December 13, 2024 18:58

Added the comments and TODO in the service.

edea203

Rearange the service for better readability,

e9912ee

Added a build.gradle file in the component.

Added upgrade data.

108e326

Shinde-nutan marked this pull request as ready for review December 16, 2024 05:36

rehan3586 reviewed Dec 16, 2024

View reviewed changes

data/ServiceJobData.xml Outdated Show resolved Hide resolved

Shinde-nutan added 3 commits December 17, 2024 10:32

Added the support to include and exclude the order based on the shipp…

b8c3c6d

…ing method in the generate#CreateOrderFeed.

fetching the discount adjustement from OrderItemAdjustmentAndAttribute

29941ad

view instead of OrderAdjustment entity

Added the upgrade steps

0aaeade

Shinde-nutan self-assigned this Dec 17, 2024

Shinde-nutan added 2 commits December 19, 2024 16:18

Added the system messsage for pos order feed.

aed360e

remove the sales channel enum code after processing.

f71111e

dt2patel requested changes Dec 31, 2024

View reviewed changes

Shinde-nutan added 2 commits January 9, 2025 04:55

Updated the file name and job name

d17398c

updated the view name as improved in the view entity.

6eeb1e1

dt2patel merged commit 56f870a into hotwax:main Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the service to generate the feed file #3

Added the service to generate the feed file #3

Shinde-nutan commented Dec 4, 2024

dt2patel Dec 4, 2024

Shinde-nutan Dec 16, 2024

dt2patel Dec 4, 2024

dt2patel Dec 4, 2024

dt2patel left a comment

dt2patel Dec 31, 2024

Shinde-nutan Dec 31, 2024

dt2patel Dec 31, 2024

dt2patel Dec 31, 2024

Shinde-nutan Dec 31, 2024

dt2patel Dec 31, 2024

dt2patel Dec 31, 2024

dt2patel Dec 31, 2024

Shinde-nutan Dec 31, 2024

Shinde-nutan Jan 9, 2025 •

edited

Loading

	<log message="Generating Create Orders Feed file of HotWax for Order ${orderId} at time ${nowDate}"/>
	<log message="Generating Order Feed file for order ${orderId} at time ${nowDate}"/>

	<!-- If no orders in BrokeredOrderItemsSyncQueue, then don't generate the file -->
	<!-- If no orders in BrokeredOrderItemsSyncQueue, then don't generate the file -->

	<set field="totalNonRefundedGiftCardAmount" type="Integer"/>
	<set field="totalValidGiftCardAmount" type="Integer"/>

Added the service to generate the feed file #3

Added the service to generate the feed file #3

Conversation

Shinde-nutan commented Dec 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dt2patel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shinde-nutan Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Shinde-nutan Jan 9, 2025 •

edited

Loading