Skip to content

Commit

Permalink
Merge pull request #581 from amansinghbais/#580
Browse files Browse the repository at this point in the history
Improved: route for hard counts detail age, highlighting the tab for count details page, persisting detail when moving back from settings to count(#580)
  • Loading branch information
ymaheshwari1 authored Jan 7, 2025
2 parents 91575f2 + 2295cb6 commit fa24c85
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/Menu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default defineComponent({
url: "/draft",
iosIcon: createOutline,
mdIcon: createOutline,
childRoutes: ["/draft/", "/bulkUpload", "/hard-count", "/hard-count-detail"],
childRoutes: ["/draft/", "/bulkUpload", "/hard-count"],
meta: {
permissionId: "APP_DRAFT_VIEW"
}
Expand Down
2 changes: 1 addition & 1 deletion src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const routes: Array<RouteRecordRaw> = [
}
},
{
path: 'hard-count-detail/:id',
path: 'count-detail/hard/:id',
name: 'HardCountDetail',
component: HardCountDetail,
props: true,
Expand Down
2 changes: 1 addition & 1 deletion src/views/Count.vue
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ async function segmentChanged(value) {
}
function navigateToStoreView(count) {
router.push((count.countTypeEnumId === "HARD_COUNT" && count.statusId === "INV_COUNT_ASSIGNED") ? `/tabs/hard-count-detail/${count.inventoryCountImportId}` : `/tabs/count-detail/${count.inventoryCountImportId}`);
router.push((count.countTypeEnumId === "HARD_COUNT" && count.statusId === "INV_COUNT_ASSIGNED") ? `/tabs/count-detail/hard/${count.inventoryCountImportId}` : `/tabs/count-detail/${count.inventoryCountImportId}`);
}
function getStatusIdForCountsToBeFetched() {
Expand Down
2 changes: 1 addition & 1 deletion src/views/Tabs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<ion-tabs>
<ion-router-outlet></ion-router-outlet>
<ion-tab-bar slot="bottom">
<ion-tab-button tab="orders" @click="$router.push('/tabs/count')" href="/tabs/count">
<ion-tab-button tab="orders" href="/tabs/count">
<ion-icon :icon="infiniteOutline" />
<ion-label>{{ translate("Counts") }}</ion-label>
</ion-tab-button>
Expand Down

0 comments on commit fa24c85

Please sign in to comment.