Fixed: Miscellaneous issues in new facility group UI (#293) #300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#293
Short Description and Why It's Useful
Fixed following issues -
#1 - It's observed that an alert doesn't trigger, and the sequence gets saved when the user tries to go back after saving the sequence for the first time. Hence, reopening this ticket.
#2 - Facilities count is not getting updated when user creates new group, unlink the facility after linking and then save the changes.
#3 - Facility counts disappear from group cards after navigating between the 'Facility Groups' and 'Parent Groups Associations' tabs without saving changes to facility sequencing.
#4 - Unnecessary scrollbar is present in 'Parent Group Association' tab. On scrolling the page, it gets disappear.
#5 - API gets fail and description(long) is not getting updated. Toast message is also not correct in this case. Also description is not getting saved in the format provided by the user(next line).
#7 - 'Selected groups' count of each parent group is set as '10' instead of showing the actual count.
#8 - When a parent group's selected group count is displayed as 1, only one group should be marked as checked upon scrolling. However, it is observed that more than one group is checked when scrolling, and the selected group count incorrectly updates from 1 to the actual number of checked groups.
#9 - If 'Parent Groups Associations' tab is opened and when user switches the section(like from 'Facilities' to 'Groups'), the 'Facility Group' tab should get opened instead of 'Parent Groups Associations'.(this behavior is working fine in case of ATP and Job Manager App)
#10 - No empty state is present in case no facility is linked with the selected group.
#11 - Unlinked facility group is visible in the sell online card of facility even though the facility is unlinked from its group from the groups section.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance