Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Miscellaneous issues in new facility group UI (#293) #300

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

ravilodhi
Copy link
Contributor

@ravilodhi ravilodhi commented Aug 22, 2024

Related Issues

#293

Short Description and Why It's Useful

Fixed following issues -
#1 - It's observed that an alert doesn't trigger, and the sequence gets saved when the user tries to go back after saving the sequence for the first time. Hence, reopening this ticket.

#2 - Facilities count is not getting updated when user creates new group, unlink the facility after linking and then save the changes.

#3 - Facility counts disappear from group cards after navigating between the 'Facility Groups' and 'Parent Groups Associations' tabs without saving changes to facility sequencing.

#4 - Unnecessary scrollbar is present in 'Parent Group Association' tab. On scrolling the page, it gets disappear.

#5 - API gets fail and description(long) is not getting updated. Toast message is also not correct in this case. Also description is not getting saved in the format provided by the user(next line).

#7 - 'Selected groups' count of each parent group is set as '10' instead of showing the actual count.

#8 - When a parent group's selected group count is displayed as 1, only one group should be marked as checked upon scrolling. However, it is observed that more than one group is checked when scrolling, and the selected group count incorrectly updates from 1 to the actual number of checked groups.

#9 - If 'Parent Groups Associations' tab is opened and when user switches the section(like from 'Facilities' to 'Groups'), the 'Facility Group' tab should get opened instead of 'Parent Groups Associations'.(this behavior is working fine in case of ATP and Job Manager App)

#10 - No empty state is present in case no facility is linked with the selected group.

#11 - Unlinked facility group is visible in the sell online card of facility even though the facility is unlinked from its group from the groups section.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@ravilodhi ravilodhi merged commit 3767bf6 into main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant