Merge pull request #315 from R-Sourabh/#304-primary-product-store

Improved: Added a toast when we cannot set the product store as primary due to a missing Shopify shop(#304)
hotwax · Sep 17, 2024 · d7e84a7 · d7e84a7
2 parents 42b1cea + 8950077
commit d7e84a7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/components/ProductStorePopover.vue b/src/components/ProductStorePopover.vue
@@ -118,6 +118,8 @@ export default defineComponent({
 
       // if we does not get shopify shop id for the store then not making product store as primary
       if(!shopifyShopId) {
+        showToast(translate('Failed to make product store primary due to missing Shopify shop'))
+        emitter.emit('dismissLoader')
         return;
       }
 

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -144,6 +144,7 @@
   "Failed to find the facility locations": "Failed to find the facility locations",
   "Failed to make product store as primary.": "Failed to make product store as primary.",
   "Failed to make product store primary.": "Failed to make product store primary.",
+  "Failed to make product store primary due to missing Shopify shop": "Failed to make product store primary due to missing Shopify shop",
   "Failed to regenerate latitude and longitude for the facility.": "Failed to regenerate latitude and longitude for the facility.",
   "Failed to rename facility.": "Failed to rename facility.",
   "Failed to remove facility latitude and longitude.": "Failed to remove facility latitude and longitude.",

diff --git a/src/views/FacilityDetails.vue b/src/views/FacilityDetails.vue
@@ -172,7 +172,7 @@
             </ion-card-header>
             <ion-item v-for="store in facilityProductStores" :key="store.productStoreId">
               <ion-label>{{ getProductStore(store.productStoreId)?.storeName }}</ion-label>
-              <ion-badge slot="end" v-if="shopifyShopIdForProductStore(store.productStoreId) === current.primaryFacilityGroupId">{{ translate("primary store") }}</ion-badge>
+              <ion-badge slot="end" v-if="shopifyShopIdForProductStore(store.productStoreId) !== '' && shopifyShopIdForProductStore(store.productStoreId) === current.primaryFacilityGroupId">{{ translate("primary store") }}</ion-badge>
               <ion-button slot="end" fill="clear" color="medium" @click="productStorePopover($event, store)">
                 <ion-icon slot="icon-only" :icon="ellipsisVerticalOutline" />
               </ion-button>