Improved: method name for removing primary status, and added comments…

… for better understanding (#10)
hotwax · Nov 27, 2023 · c301ab1 · c301ab1
1 parent 68819c3
commit c301ab1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/components/ProductStorePopover.vue b/src/components/ProductStorePopover.vue
@@ -65,7 +65,7 @@ export default defineComponent({
 
           // Removing store from primary Member group if primary.
           if(this.currentProductStore.productStoreId === this.primaryMember.facilityGroupId){
-            await this.removeProductFromPrimaryMember()
+            await this.revokePrimaryStatusFromStore()
           }
 
           // refetching product stores with updated roles
@@ -82,16 +82,20 @@ export default defineComponent({
     async makePrimary() {
       const productStoreId = this.currentProductStore.productStoreId
       if(this.primaryMember.facilityGroupId === productStoreId) {
-        this.removeProductFromPrimaryMember()
+        this.revokePrimaryStatusFromStore()
         popoverController.dismiss()
         return;
       }
 
       let resp;
       let facilityGroupId;
 
+      // Fetching the facility group corresponding to the selected product store.
+      // There should be one facility group where facilityGroupId equals to productStoreId in order
+      // to manage primary product store of a facility.
       facilityGroupId = await this.fetchFacilityGroup(productStoreId)
 
+      // Create one facility group corresponding to the selected product store if not exists.
       if(!facilityGroupId) {
         facilityGroupId = await this.createFacilityGroup(productStoreId)
       } 
@@ -106,7 +110,7 @@ export default defineComponent({
           if(!hasError(resp)) {
             // Remove old primary store
             if(this.primaryMember.facilityGroupId) {
-              await this.removeProductFromPrimaryMember()
+              await this.revokePrimaryStatusFromStore()
             }
           } else {
             throw resp.data
@@ -162,7 +166,7 @@ export default defineComponent({
 
       return facilityGroupId
     },
-    async removeProductFromPrimaryMember() {
+    async revokePrimaryStatusFromStore() {
       let resp;
       try {
         resp = await FacilityService.updateFacilityToGroup({

diff --git a/src/views/FacilityDetails.vue b/src/views/FacilityDetails.vue
@@ -561,7 +561,7 @@ export default defineComponent({
           } else {
             productStoresToRemove.map((store: any) => {
               if(store.productStoreId === this.primaryMember.facilityGroupId) {
-                this.removeProductFromPrimaryMember()
+                this.revokePrimaryStatusFromStore()
               }
             })
             showToast(translate("Product stores updated successfully."))
@@ -701,7 +701,7 @@ export default defineComponent({
         logger.error('Failed to update fulfillment setting', err)
       }
     },
-    async removeProductFromPrimaryMember() {
+    async revokePrimaryStatusFromStore() {
       let resp;
       try {
         resp = await FacilityService.updateFacilityToGroup({