Improved: popover component name, conditions in getProductStores acti…

…on (#10)
hotwax · Nov 17, 2023 · aada1d4 · aada1d4
1 parent 7f39d25
commit aada1d4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/src/components/OpenStorePopover.vue → src/components/ProductStorePopover.vue b/src/components/OpenStorePopover.vue → src/components/ProductStorePopover.vue
@@ -28,11 +28,12 @@ import { translate } from "@hotwax/dxp-components";
 import { mapGetters, useStore } from "vuex";
 import { FacilityService } from "@/services/FacilityService";
 import { DateTime } from "luxon";
-import { hasError } from "@hotwax/oms-api";
+import { hasError } from "@/adapter";
 import { showToast } from "@/utils";
+import logger from "@/logger";
 
 export default defineComponent({
-  name: "OpenStorePopover",
+  name: "ProductStorePopover",
   components: {
     IonContent,
     IonList,
@@ -62,9 +63,11 @@ export default defineComponent({
 
           // refetching product stores with updated roles
           await this.store.dispatch('facility/getFacilityProductStores', { facilityId: this.facilityId })
+        } else {
+          throw resp.data
         }
       } catch(err) {
-        console.error(err)
+        logger.error(err)
         showToast(translate('Store unlink failed.'))
       }
     },

diff --git a/src/store/modules/facility/actions.ts b/src/store/modules/facility/actions.ts
@@ -143,7 +143,7 @@ const actions: ActionTree<FacilityState, RootState> = {
     commit(types.FACILITY_LIST_UPDATED , { facilities: [], total: 0 });
   },
 
-  async getFacilityProductStores({ commit, state }, params) {
+  async getFacilityProductStores({ commit }, params) {
     let productStores = []
     const payload = {
       inputFields: {
@@ -158,13 +158,13 @@ const actions: ActionTree<FacilityState, RootState> = {
     try {
       const resp = await FacilityService.getFacilityProductStores(payload)
 
-      if (!hasError(resp) || resp.data.error === 'No record found') {
-        productStores = resp.data.docs ? resp.data.docs : []
+      if(!hasError(resp) && resp.data.count) {
+        productStores = resp.data.docs
       } else {
         throw resp.data
       }
-    } catch (error) {
-      console.error('Failed to fetch user associated product stores.', error)
+    } catch(error) {
+      logger.error(error)
     }
 
     commit(types.FACILITY_PRODUCT_STORES_UPDATED , productStores);

diff --git a/src/views/FacilityDetails.vue b/src/views/FacilityDetails.vue
@@ -151,7 +151,7 @@
                 <h2>{{ getStoreDetail(store.productStoreId).storeName }}</h2>
               </ion-label>
               <ion-badge>{{ translate("primary store") }}</ion-badge>
-              <ion-button slot="end" fill="clear" color="medium" @click="openStorePopover($event, store)">
+              <ion-button slot="end" fill="clear" color="medium" @click="productStorePopover($event, store)">
                 <ion-icon slot="icon-only" :icon="ellipsisVerticalOutline" />
               </ion-button>
             </ion-item>
@@ -401,7 +401,7 @@ import {
 import { translate } from '@hotwax/dxp-components';
 import AddExternalMappingPopover from '@/components/AddExternalMappingPopover.vue'
 import LocationDetailsPopover from '@/components/LocationDetailsPopover.vue';
-import OpenStorePopover from '@/components/OpenStorePopover.vue';
+import ProductStorePopover from '@/components/ProductStorePopover.vue';
 import AddAddressModal from '@/components/AddAddressModal.vue'
 import AddGeoPointModal from '@/components/AddGeoPointModal.vue';
 import SelectProductStoreModal from '@/components/SelectProductStoreModal.vue'
@@ -462,9 +462,9 @@ export default defineComponent({
     await this.store.dispatch('facility/getFacilityProductStores', { facilityId: this.facilityId })
   },
   methods: {
-    async openStorePopover(ev: Event, store: any) {
+    async productStorePopover(ev: Event, store: any) {
       const popover = await popoverController.create({
-        component: OpenStorePopover,
+        component: ProductStorePopover,
         componentProps: {
           facilityId: this.facilityId,
           currentProductStore: store