Merge pull request #171 from Ritika-Patel08/#163

Fixed: Added missing static text translation in locales file and imported ion-text element in FacilityDetails page(#163)
hotwax · Jan 10, 2024 · 561ce20 · 561ce20
2 parents 0f8b3d9 + fb43935
commit 561ce20
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/components/CreateFacilityLoginModal.vue b/src/components/CreateFacilityLoginModal.vue
@@ -56,6 +56,7 @@ import {
   IonLabel,
   IonList,
   IonNote,
+  IonText,
   IonTitle,
   IonToolbar,
   modalController
@@ -90,6 +91,7 @@ export default defineComponent({
     IonLabel,
     IonList,
     IonNote,
+    IonText,
     IonTitle,
     IonToolbar,
   },

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -1,6 +1,7 @@
 {
   "Add": "Add",
   "Add address later": "Add address later",
+  "Add description": "Add description",
   "Add Group": "Add Group",
   "Add locations to facility": "Add locations to facility",
   "Add group description": "Add group description",
@@ -45,14 +46,19 @@
   "Configure the order fulfillment capacity of your facility.": "Configure the order fulfillment capacity of your facility.",
   "Confirm": "Confirm",
   "Consumed Order Limit": "Consumed Order Limit",
+  "Create ": "Create ",
   "Create Distribution Center login": "Create Distribution Center login",
   "Create group": "Create group",
   "Create login credentials": "Create login credentials",
   "Create Outlet Store": "Create Outlet Store",
+  "Create Outlet Store login": "Create Outlet Store login",
   "Create Outlet Warehouse": "Create Outlet Warehouse",
+  "Create Outlet Warehouse login": "Create Outlet Warehouse login",
   "Create Physical Store login": "Create Physical Store login",
   "Create Retail Store": "Create Retail Store",
+  "Create Retail Store login": "Create Retail Store login",
   "Create Warehouse": "Create Warehouse",
+  "Create Warehouse login": "Create Warehouse login",
   "Custom": "Custom",
   "Custom fulfillment capacity": "Custom fulfillment capacity",
   "Custom mapping": "Custom mapping",
@@ -70,6 +76,7 @@
   "Failed to associate calendar to the facility.": "Failed to associate calendar to the facility.",
   "Filters": "Filters",
   "Edit": "Edit",
+  "Edit description": "Edit description",
   "Edit group description": "Edit group description",
   "Edit location": "Edit location",
   "End Time": "End Time",
@@ -194,6 +201,7 @@
   "Logging in": "Logging in",
   "Logging out": "Logging out",
   "Login": "Login",
+  "logins": "{facilitytype} logins",
   "Login failed": "Login failed",
   "Logout": "Logout",
   "Longitude": "Longitude",

diff --git a/src/views/FacilityDetails.vue b/src/views/FacilityDetails.vue
@@ -256,7 +256,7 @@
           <ion-card>
             <ion-card-header>
               <ion-card-title>
-                {{ translate(`${facilityTypes[current.facilityTypeId]?.description} logins`) }}
+                {{ facilityTypes[current.facilityTypeId]?.description ? translate(`${facilityTypes[current.facilityTypeId]?.description} logins`) : translate('logins', { facilitytype:`${current.facilityTypeId}` }) }}
               </ion-card-title>
               <ion-button v-if="current.facilityLogins?.length" @click="createFacilityLoginModal()" fill="clear">
                 <ion-icon :icon="addCircleOutline" slot="end" />