Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: NetSuite Integration Management UI(#37) #38

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Sep 28, 2024

Related Issues

#37

Short Description and Why It's Useful

  • Implemented the UI for the NetSuite Integration Management.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-09-30 16-42-52
Screenshot from 2024-09-30 16-42-47
Screenshot from 2024-09-30 16-42-41
Screenshot from 2024-09-30 16-42-35
Screenshot from 2024-09-30 16-42-29
Screenshot from 2024-09-30 16-42-23
Screenshot from 2024-09-30 16-42-16
Screenshot from 2024-09-30 16-42-08
Screenshot from 2024-09-30 16-41-45
Screenshot from 2024-09-30 16-41-38
Screenshot from 2024-09-30 16-41-32
Screenshot from 2024-09-30 16-41-15

Contribution and Currently Important Rules Acceptance

@R-Sourabh R-Sourabh marked this pull request as ready for review September 30, 2024 11:18
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

</script>

<style scoped>
main {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use main element here? we can simply just add ion padding to ion content right? @R-Sourabh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure sir.

<ion-icon slot="end" :icon="chevronForwardOutline"/>
</ion-item>
</ion-card>
<ion-card>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't use ion-card here. Like in Figma, directly use ion item with outline and border radius. We should make this a global style in our app themes. We use this item pattern in the fulfillment app and I expect to use it again. @R-Sourabh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood that sir, I'll change it.


<div class="ion-margin-top">
<ion-text>Configuration</ion-text>
<section>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this UI patter in itself will be, or has been frequently reused. Lets make a DXP component where you can pass in:

list of item labels and p tags in labels. You can also pass in the action icon that will be displayed on each of the items' end slots.

something like:

title: section-name
itemEndIcon: icon-name
items: [{primary label, secondary label}]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll look into this.

Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback

}

.item-box::part(native) {
border-radius: 8px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just use the ion item custom property for border radius?
https://ionicframework.com/docs/api/item#css-custom-properties-1

--border-radius

grid-template-columns: repeat(auto-fill, minmax(300px, 1fr));
gap: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use spacer variables here instead of hard coded value. I know you are recreating the default margin of ion card, but if you're replacing, it is recommended to use premade spacer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants