Implemented: Gitbook lens search feature #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amansinghbais
changed the title
amansinghbais
changed the title
ymaheshwari1
requested changes
Jun 14, 2024
src/services/UtilService.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| import api from "@/api" | |||
| import api, {client} from "@/api" | |||
| import { hasError } from "@/utils"; | |||
There was a problem hiding this comment.
Remove unused imports.
src/services/UtilService.ts
Outdated
| const baseURL = `https://api.gitbook.com/v1/spaces/${process.env.VUE_APP_SPACE_ID}/search/` | ||
|
|
||
| return await client({ | ||
| url: `ask`, |
There was a problem hiding this comment.
Suggested change
| url: `ask`, | |
| url: "ask" |
src/services/UtilService.ts
Outdated
| headers: { | ||
| Authorization: 'Bearer ' + token, | ||
| "Content-Type": "application/json", | ||
| "Access-Control-Allow-Origin": "*" |
There was a problem hiding this comment.
I think this is not required.
src/services/UtilService.ts
Outdated
| }) as any; | ||
| } | ||
|
|
||
| const getGitboookPage = async (pageId: any): Promise <any> => { |
There was a problem hiding this comment.
Suggested change
| const getGitboookPage = async (pageId: any): Promise <any> => { | |
| const getGitBookPage = async (pageId: any): Promise <any> => { |
src/services/UtilService.ts
Outdated
|
|
||
| const getGitboookPage = async (pageId: any): Promise <any> => { | ||
| const token = process.env.VUE_APP_GITBOOK_API_KEY; | ||
| const baseURL = `https://api.gitbook.com/v1/spaces/${process.env.VUE_APP_SPACE_ID}/` |
There was a problem hiding this comment.
We can keep the gitbook api endpoint in the env https://api.gitbook.com/v1/spaces/
Suggested change
| const baseURL = `https://api.gitbook.com/v1/spaces/${process.env.VUE_APP_SPACE_ID}/` | |
| const baseURL = `https://api.gitbook.com/v1/spaces/${process.env.VUE_APP_SPACE_ID}/` |
ymaheshwari1
requested changes
Jun 14, 2024
src/components/GitBookSearch.vue
Outdated
| <ion-toolbar> | ||
| <ion-buttons slot="start"> | ||
| <ion-button @click="closeModal"> | ||
| <ion-icon :icon="close" /> |
ymaheshwari1
approved these changes
Jun 14, 2024
… gitbook api calls (hotwax#23)
ymaheshwari1
requested changes
Jun 17, 2024
| if (token) { | ||
|
|
||
| // TODO: think of better solution to avoid sending api_key for external apis. | ||
| if (token && !config.baseURL.includes("gitbook")) { |
There was a problem hiding this comment.
We can check for Authorization field in the config headers, if found we will not add the api_key.
So that it will not be specific to gitbook.
|
Has implemented this with different approach in following PR : #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance