Skip to content

Commit

Permalink
Improved: brokering icon, added placeholder on the ion-select (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
@amansinghbais
amansinghbais committed May 29, 2024
1 parent 17151aa commit e1c108f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
3 changes: 2 additions & 1 deletion src/locales/en.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"Go to OMS": "Go to OMS",
"Hold pre-order physical inventory": "Hold pre-order physical inventory",
"ID": "ID",
"Id prefix": "Id prefix",
"ID prefix": "ID prefix",
"Identifier": "Identifier",
"Import": "Import",
"Inventory": "Inventory",
Expand Down Expand Up @@ -101,6 +101,7 @@
"Search time zones": "Search time zones",
"Soft Allocation": "Soft Allocation",
"Secondary identifier": "Secondary identifier",
"Select": "Select",
"Select operating countries": "Select operating countries",
"Select time zone": "Select time zone",
"Send notification to Shopify": "Send notification to Shopify",
Expand Down
16 changes: 8 additions & 8 deletions src/views/ProductStoreDetails.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</ion-item>

<ion-item>
<ion-icon :icon="thunderstormOutline" slot="start"/>
<ion-icon :icon="compassOutline" slot="start"/>
<ion-toggle :checked="getBooleanValue(productStore.enableBrokering)" @click.prevent="updateProductStoreDetail($event, 'enableBrokering', true)">{{ translate("Order brokering") }}</ion-toggle>
</ion-item>

Expand All @@ -52,7 +52,7 @@
</ion-item-divider>

<ion-item>
<ion-input :label="translate('Id prefix')" :placeholder="translate('prefix')" :value="productStore.orderNumberPrefix" @keydown.enter="updateProductStoreDetail($event, 'orderNumberPrefix', false)" />
<ion-input :label="translate('ID prefix')" :placeholder="translate('prefix')" :value="productStore.orderNumberPrefix" @keydown.enter="updateProductStoreDetail($event, 'orderNumberPrefix', false)" />
</ion-item>
<ion-item lines="none">
<ion-label>
Expand Down Expand Up @@ -245,7 +245,7 @@
</ion-item>

<ion-item>
<ion-select :label="translate('Pre-order group')" interface="popover" :value="settings['PRE_ORDER_GROUP_ID']?.settingValue" @ionChange="updateProductStoreSettings($event, 'PRE_ORDER_GROUP_ID', false)">
<ion-select :label="translate('Pre-order group')" interface="popover" :placeholder="translate('Select')" :value="settings['PRE_ORDER_GROUP_ID']?.settingValue" @ionChange="updateProductStoreSettings($event, 'PRE_ORDER_GROUP_ID', false)">
<ion-select-option v-for="group in facilityGroups" :key="group.facilityGroupId" :value="group.facilityGroupId">{{ group.facilityGroupName }}</ion-select-option>
</ion-select>
</ion-item>
Expand All @@ -268,7 +268,7 @@
</ion-item-divider>

<ion-item>
<ion-select :label="translate('Global identifier')" interface="popover" :value="productStore.productIdentifierEnumId" @ionChange="updateProductStoreDetail($event, 'productIdentifierEnumId', false)">
<ion-select :label="translate('Global identifier')" interface="popover" :placeholder="translate('Select')" :value="productStore.productIdentifierEnumId" @ionChange="updateProductStoreDetail($event, 'productIdentifierEnumId', false)">
<ion-select-option v-for="identifier in productIdentifiers" :key="identifier.enumId" :value="identifier.enumId">{{ identifier.description }}</ion-select-option>
</ion-select>
</ion-item>
Expand All @@ -283,13 +283,13 @@
</ion-item-divider>

<ion-item>
<ion-select :label="translate('Primary identifier')" interface="popover" :value="getPreferredIdentification('primaryId')" @ionChange="updatePreferredIdentification($event, 'primaryId')">
<ion-select :label="translate('Primary identifier')" interface="popover" :placeholder="translate('Select')" :value="getPreferredIdentification('primaryId')" @ionChange="updatePreferredIdentification($event, 'primaryId')">
<ion-select-option v-for="option in productIdentificationOptions" :key="option" :value="option">{{ option }}</ion-select-option>
</ion-select>
</ion-item>

<ion-item>
<ion-select :label="translate('Secondary identifier')" interface="popover" :value="getPreferredIdentification('secondaryId')" @ionChange="updatePreferredIdentification($event, 'secondaryId')">
<ion-select :label="translate('Secondary identifier')" interface="popover" :placeholder="translate('Select')" :value="getPreferredIdentification('secondaryId')" @ionChange="updatePreferredIdentification($event, 'secondaryId')">
<ion-select-option v-for="option in productIdentificationOptions" :key="option" :value="option">{{ option }}</ion-select-option>
</ion-select>
</ion-item>
Expand All @@ -316,7 +316,7 @@
</ion-item>

<ion-item>
<ion-select :label="translate('Shipment method')" interface="popover" :value="settings['RF_SHIP_MTHD']?.settingValue" @ionChange="updateProductStoreSettings($event, 'RF_SHIP_MTHD', false)" >
<ion-select :label="translate('Shipment method')" interface="popover" :placeholder="translate('Select')" :value="settings['RF_SHIP_MTHD']?.settingValue" @ionChange="updateProductStoreSettings($event, 'RF_SHIP_MTHD', false)" >
<ion-select-option v-for="shipmentMethod in shipmentMethodTypes" :key="shipmentMethod.shipmentMethodTypeId" :value="shipmentMethod.shipmentMethodTypeId">{{ shipmentMethod.description ? shipmentMethod.description : shipmentMethod.shipmentMethodTypeId }}</ion-select-option>
</ion-select>
</ion-item>
Expand Down Expand Up @@ -347,7 +347,7 @@

<script setup lang="ts">
import { IonBackButton, IonButton, IonCard, IonCardHeader, IonCardSubtitle, IonCardTitle, IonContent, IonChip, IonHeader, IonIcon, IonInput, IonItem, IonItemDivider, IonLabel, IonList, IonPage, IonSelect, IonSelectOption, IonTitle, IonToggle, IonToolbar, alertController, onIonViewWillEnter } from "@ionic/vue";
import { addCircleOutline, closeCircleOutline, mapOutline, thunderstormOutline, wineOutline } from "ionicons/icons";
import { addCircleOutline, closeCircleOutline, compassOutline, mapOutline, wineOutline } from "ionicons/icons";
import { translate } from "@/i18n";
import { useStore } from "vuex";
import { computed, defineProps, ref } from "vue";
Expand Down

0 comments on commit e1c108f

Please sign in to comment.