Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Make OSM login mandatory for project creation #1738 #1836

Closed
wants to merge 1 commit into from

Conversation

Anuj-Gupta4
Copy link

@Anuj-Gupta4 Anuj-Gupta4 commented Oct 24, 2024

What type of PR is this? (check all applicable)

  • 🍕 Feature

Related Issue

Fixes #1738

Describe this PR

Only users logged in using OSM may create projects

Review Guide

Test if create-project api works as expected

Checklist before requesting a review

@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code backend Related to backend code contrib External contributions, or not related to core functionality tests Related to automated code tests labels Oct 24, 2024
@Anuj-Gupta4 Anuj-Gupta4 changed the base branch from development to staging October 24, 2024 09:53
@spwoodcock
Copy link
Member

Hi @Anuj-Gupta4 !

Thank you so much for contributing 🙏

Unfortunately I think I worded the issue quite badly, so it might have been misunderstood what is required 😅

We already have osm login implemented actually. So what the issue is describing is perhaps only allowing a few specific endpoints to be accessible using the temporary login cookie.

For example, users should not be able to create new projects using the temporary cookie

@spwoodcock
Copy link
Member

On second thoughts, perhaps solving

#1785

might actually mean this issue no longer needs to be solved 😆

@spwoodcock
Copy link
Member

Closing in favour of #1845

@spwoodcock spwoodcock closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working contrib External contributions, or not related to core functionality frontend Related to frontend code tests Related to automated code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent API usage with temp credentials, except specific mapper endpoints
2 participants