clean empty datetime fields in fallback sink #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsyyid
reviewed
Oct 23, 2024
| @@ -882,6 +882,13 @@ def preprocess_record(self, record, context): | |||
| except MissingObjectInSalesforceError: | |||
| self.logger.info("Skipping record, because it was not found on Salesforce.") | |||
| return {} | |||
|
|
|||
| # keep only available fields and that are creatable or updatable | |||
| record = {k:v for k,v in record.items() if fields.get(k) and (fields[k]["createable"] or fields[k]["updateable"])} | |||
There was a problem hiding this comment.
If it's a boolean and it's False will this still work?
There was a problem hiding this comment.
all values inside fields are dicts and both both createable and updateable are boolean values, so I think it should work if the field is either createable or updateable
hsyyid
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.