Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGI-5432 \ Add jitter to always wait 120s when retrying #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

HGI-5432 \ Add jitter to always wait 120s when retrying #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e29c05
add jitter to always wait 120s when retrying
arilton Sep 11, 2024
23e1a14
move extra sleep time to giveup function
arilton Sep 12, 2024
61f4b3f
exponential backoff time
arilton Sep 16, 2024
e55dcf7
add more logs to giveup handler
arilton Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions tap_hubspot/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/usr/bin/env python3
import datetime
import time
import pytz
import itertools
import os
Expand Down Expand Up @@ -246,9 +247,29 @@ def acquire_access_token_from_refresh_token():


def giveup(exc):
return exc.response is not None \
and 400 <= exc.response.status_code < 500 \
and exc.response.status_code != 429
# Check if the exception has a response attribute with a status_code
if not getattr(exc, 'response', None) or exc.response is None:
return False

status_code = getattr(exc.response, 'status_code', None)

if status_code is None:
LOGGER.warning("Exception response has no status_code.")
return False

# If the status code is not 429 (rate limit) sleep and continue
if status_code == 429:
time_avoid_rate_limit_in_seconds = 30
LOGGER.info(f"Sleeping for {time_avoid_rate_limit_in_seconds} seconds due to status code {status_code}.")
time.sleep(time_avoid_rate_limit_in_seconds)
return False

# If the status code is in the range of 400 to 499
if 400 <= status_code < 500:
LOGGER.info(f"Non-retriable error with status code {status_code}.")
return True

return False
Comment on lines +250 to +272
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check if the exception has a response attribute with a status_code
if not getattr(exc, 'response', None) or exc.response is None:
return False
status_code = getattr(exc.response, 'status_code', None)
if status_code is None:
LOGGER.warning("Exception response has no status_code.")
return False
# If the status code is not 429 (rate limit) sleep and continue
if status_code == 429:
time_avoid_rate_limit_in_seconds = 30
LOGGER.info(f"Sleeping for {time_avoid_rate_limit_in_seconds} seconds due to status code {status_code}.")
time.sleep(time_avoid_rate_limit_in_seconds)
return False
# If the status code is in the range of 400 to 499
if 400 <= status_code < 500:
LOGGER.info(f"Non-retriable error with status code {status_code}.")
return True
return False
# Check if the exception has a response attribute with a status_code
if not getattr(exc, 'response', None) or exc.response is None:
return False
status_code = getattr(exc.response, 'status_code', None)
if status_code is None:
LOGGER.warning("Exception response has no status_code.")
return False
# If the status code is not 429 (rate limit) sleep and continue
if status_code == 429:
time_avoid_rate_limit_in_seconds = 30
LOGGER.info(f"Sleeping for {time_avoid_rate_limit_in_seconds} seconds due to status code {status_code}.")
time.sleep(time_avoid_rate_limit_in_seconds)
return False
# If the status code is in the range of 400 to 499
if 400 <= status_code < 500:
LOGGER.info(f"Non-retriable error with status code {status_code}.")
return True
return False

I messed with the indentation level before! Now it might be fixed 🙏


def on_giveup(details):
if len(details['args']) == 2:
Expand Down Expand Up @@ -290,15 +311,16 @@ def get_params_and_headers(params):

return params, headers


@backoff.on_exception(backoff.constant,
@backoff.on_exception(backoff.expo,
(requests.exceptions.RequestException,
requests.exceptions.HTTPError),
max_tries=5,
jitter=None,
giveup=giveup,
on_giveup=on_giveup,
interval=10)
base=2,
factor=5,
max_value=60)
def request(url, params=None):

params, headers = get_params_and_headers(params)
Expand Down