Fix crash when pns is walking around arcs #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have this as two separate commits:
|
added 2 commits
September 15, 2023 20:31
Type() is not printed in assert messages. Introduce TypeName() instead.
pns crashes when in walkaround mode and track collides with an arc. Fix ported from Kicad: https://gitlab.com/kicad/code/kicad/-/commit/df9cf0a0c39ed99527b0c04e3892e8dd7ed603e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When routing a track in walkaround mode, horizon crashes when the routed track collides with an arc. This due to the assert statement:
horizon-imp: ../3rd_party/router/kimath/src/geometry/shape_collisions.cpp:504: bool Collide(const SHAPE_ARC&, const SHAPE_CIRCLE&, int, int*, VECTOR2I*, VECTOR2I*): Assertion (!aMTV) failed.In KiCad this assert statement was removed to fix this problem, so i think it should be ok to do the same here.
https://gitlab.com/kicad/code/kicad/-/commit/df9cf0a0c39ed99527b0c04e3892e8dd7ed603e7
Would be nicer to port the entire KiCad Router 7.0.7 or at least 6.0.11 to horizon, but i tried and then decided it is to much trouble for just a small fix.