Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issue #19 feat: improve existing button components #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

The-x-35
Copy link

I solved the issue #19 . Combined primary and secondary button into a single component and edited their all instances in the code to fit the new use case, also edited the readme for the new button component. I have tested the code and also tested all the instances where the button was being used and they all work perfectly.

…ted their all instances in the code to fit the new use case, also edited the readme for the new button component
Copy link
Member

@anwarulislam anwarulislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was not just to remove ButtonSecondary. Instead, we will be using the same button component, where a prop will differentiate the type of the button.

@The-x-35
Copy link
Author

How will I achieve that sir ?
I am confused on how to proceed with that one ?
I commented my approach on the issue that I will remove the secondary button and do this, so I was assigned this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants