Add onChipAddListener #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshsoni1110
commented
Dec 17, 2018
harshsoni1110
commented
- Callback for new chip added.
- Callback for new chip added.
|
|
simon-tse-hs
suggested changes
Jan 4, 2019
| @@ -53,12 +57,28 @@ public int findAndHandleChipTerminators(@NonNull ChipTokenizer tokenizer, @NonNu | |||
| switch (behavior) { | |||
| case BEHAVIOR_CHIPIFY_ALL: | |||
| selectionIndex = handleChipifyAll(textIterator, tokenizer); | |||
| if (mOnChipAddListener != null) { | |||
There was a problem hiding this comment.
@harhsoni1110 it seems that these 3 blocks do the same thing. Why not put it into a private method?
|
|
||
| @Override | ||
| public void setChipAddListener(NachoTextView.OnChipAddListener onChipAddListener) { | ||
| this.mOnChipAddListener = onChipAddListener; |
There was a problem hiding this comment.
you don't need a this since the names of the fields are different.
| @@ -1127,4 +1139,8 @@ public boolean onSingleTapUp(MotionEvent e) { | |||
| return true; | |||
| } | |||
| } | |||
|
|
|||
| public interface OnChipAddListener { | |||
| void onChipAdded(Chip chip); | |||
There was a problem hiding this comment.
Can you provide the documentation and contract of when and what the onChipAdded is supposed to adhere to? It can be similar to the onChipRemove
| @@ -796,6 +805,9 @@ public void onItemClick(AdapterView<?> adapterView, View view, int position, lon | |||
|
|
|||
| editable.replace(start, end, mChipTokenizer.terminateToken(text, data)); | |||
|
|
|||
| if (onChipAddListener != null){ | |||
| onChipAddListener.onChipAdded(getAllChips().get(getAllChips().size()-1)); | |||
There was a problem hiding this comment.
remember to format your code with Android Studio's code formatting. The -1 would be spread out to make it look nicer
| @@ -150,6 +150,8 @@ | |||
|
|
|||
| // Text entry | |||
| @Nullable | |||
| private OnChipAddListener onChipAddListener; | |||
There was a problem hiding this comment.
to stay consistent, please use mOnChipAddListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.