add Honeybadger.event interface #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send application events to the event endpoint add a timestamp issue honeybadger-io#554 honeybadger-io#554
stympy
approved these changes
Aug 28, 2024
lib/honeybadger.ex
Outdated
|
|
||
| @spec event(map()) :: :ok | ||
| def event(event_data) do | ||
| Client.send_event(event_data) |
There was a problem hiding this comment.
Could you supply a ts of DateTime.utc_now() here if one isn't present in the map?
fix event/2 to add event_type and then call to event/1 then add the timestamp in event/1 so that it's always added also mix format issue honeybadger-io#554
|
@stympy thanks for the helpful prompt review. I think those 2 issues should be addressed now. |
stympy
requested changes
Aug 29, 2024
stympy
approved these changes
Aug 29, 2024
|
Released in 0.22.0. Thanks! |
|
I've upgraded our app back to the main version. Thanks for handling it so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send application events to the event endpoint
add a timestamp
issue #554
#554