Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [ruby] Update sidekiq 6.5.10 β†’ 7.1.6 (major) #412

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 10, 2023


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ sidekiq (6.5.10 β†’ 7.1.6) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 sidekiq Denial of Service vulnerability

Versions of the package sidekiq before 7.1.3 are vulnerable to Denial
of Service (DoS) due to insufficient checks in the dashboard-charts.js
file. An attacker can exploit this vulnerability by manipulating the
localStorage value which will cause excessive polling requests.

🚨 sidekiq vulnerable to cross-site scripting

sidekiq from 7.0.4 to 7.0.7 is vulnerable to reflected cross-site scripting.
A fix was released in version 7.0.8.

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

πŸ†• redis-client (added, 0.17.0)

πŸ—‘οΈ redis (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file depfu labels Oct 10, 2023
@subzero10
Copy link
Member

@depfu rebase

@depfu depfu bot changed the title 🚨 [security] [ruby] Update sidekiq 6.4.0 β†’ 7.1.6 (major) 🚨 [security] [ruby] Update sidekiq 6.5.10 β†’ 7.1.6 (major) Oct 20, 2023
@depfu depfu bot force-pushed the depfu/update/sidekiq-7.1.6 branch from 7313152 to f9014a2 Compare October 20, 2023 15:12
@subzero10
Copy link
Member

Tests are passing but still not confident to merge. Can I get another review? @joshuap @stympy

@subzero10 subzero10 added the help wanted Extra attention is needed label Oct 20, 2023
@stympy stympy requested a review from joshuap October 20, 2023 16:32
@joshuap joshuap merged commit c8d7b6b into master Oct 21, 2023
2 checks passed
@depfu depfu bot deleted the depfu/update/sidekiq-7.1.6 branch October 21, 2023 05:58
@joshuap
Copy link
Member

joshuap commented Oct 21, 2023

We could turn off depfu for this repo tbh, I don't use this much.

@subzero10
Copy link
Member

We could turn off depfu for this repo tbh, I don't use this much.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file depfu help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants