gh-51: Fix module installation error with requests

[Alexandr153]

I think you are working with an old version of the requests module, because the latest version specifies at the very beginning how the get() object should be used:

Proposal:

import requests

requests.get()

Summary by Sourcery

Fix the module installation error by updating the code to use 'requests.get()' explicitly, ensuring compatibility with the latest version of the 'requests' library.

Bug Fixes:

• Fix module installation error by explicitly using 'requests.get()' instead of 'get()' to ensure compatibility with the latest version of the 'requests' module.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue with the module installation error related to the 'requests' library. The main change involves updating the way the 'get()' function is called, ensuring compatibility with the latest version of the 'requests' module.

File-Level Changes

Change	Details	Files
Update 'get()' function calls to use 'requests.get()'	Replace 'r = get(url, timeout=10)' with 'r = requests.get(url, timeout=10)' Replace 'r = get(url)' with 'r = requests.get(url)'	ufpy/github/download.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @Alexandr153 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (performance): Consider adding a timeout to the requests.get call in the download_file method

For consistency with the enter method and to prevent hanging on slow connections, it might be beneficial to add a timeout parameter to this request as well.

Suggested change

	r = requests.get(url, timeout=10)
	r = requests.get(url, timeout=(5, 30))

[n0n1m]

That's totally not the issue.

[n0n1m]

The issue is the library code running without requests installed

[n0n1m]

That's how discord.py addresses this issue: https://github.com/Rapptz/discord.py/blob/master/setup.py

[n0n1m]

I'll make pull request with my fix in a sec

[n0n1m]

It is literally the same thing

[n0n1m]

@bleudev I recomend closing this request

[bleudev]

@Alexandr153 It's really fixes an issue? I used this import because of i don't need to use all methods from requests. Only get(). Can you explain me this method of solving this problem?

[bleudev]

I merged #53. Can this solve this problem?

[bleudev]

@bleudev I recomend closing this request

Too