Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uSTL: Queue, Deque and Pair #39
base: main
Are you sure you want to change the base?
uSTL: Queue, Deque and Pair #39
Changes from 3 commits
158a803
5ea4271
3346d90
ec04cc1
1370403
d98aca4
3e9d811
535e603
c63432f
6e2634b
aa3d9d9
a94d526
dee4e38
59c54f4
feae104
5ec7eb7
01e3382
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Typo in UDeque Introduction
UDeque is a class which simplifies working with deque.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Clarification in UDeque Get end/begin Section
Clarify that 0 refers to the first element and 1 refers to the last element in the context of the end and begin methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Clarification in UDeque Add end/begin Section
Expand on why it is undesirable to use indexes directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Incorrect index range check in getitem
The index range check in
__getitem__
should allow for any valid index within the list, not just 0 and 1. This will cause an IndexError for valid indices beyond 1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Incorrect index range check in setitem
The index range check in
__setitem__
should allow for any valid index within the list, not just 0 and 1. This will cause an IndexError for valid indices beyond 1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Incorrect index range check in delitem
The index range check in
__delitem__
should allow for any valid index within the list, not just 0 and 1. This will cause an IndexError for valid indices beyond 1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Incorrect reversed implementation
The
__reversed__
method should return a deque with elements in reverse order, not just the end and begin elements.