Add value equality to ConditionalEffect.

RandomizerCore/StringItems/StringItem.cs

@@ -232,6 +232,16 @@ public override IExpression<ItemExpressionType> ToExpression()
             if (Negated) logicExpr = ExpressionBuilder.ApplyPrefixOperator(ExpressionBuilder.Op(ItemOperatorProvider.Negation), logicExpr);
             return ExpressionBuilder.ApplyInfixOperator(logicExpr, ExpressionBuilder.Op(ItemOperatorProvider.Conditional), Effect.ToExpression());
         }
+
+        public virtual bool Equals(ConditionalEffect? other)
+        {
+            return other is not null && other.Negated == Negated && other.Logic.GetType() == Logic.GetType() && other.Logic.InfixSource == Logic.InfixSource;
+        }
+
+        public override int GetHashCode()
+        {
+            return Logic.InfixSource.GetHashCode() * (Negated ? 2 : 1);
+        }
     }
 
     public record ReferenceEffect(LogicItem Item) : StringItemEffect

RandomizerCoreTests/StringItemEqualityTests.cs

@@ -0,0 +1,29 @@
+using FluentAssertions;
+using RandomizerCore;
+using RandomizerCore.Logic;
+using RandomizerCore.StringItems;
+namespace RandomizerCoreTests
+{
+    public class StringItemEqualityTests
+    {
+        [Theory]
+        [InlineData("_ >|> _")]
+        [InlineData("`A>1` => A++")]
+        [InlineData("`A<1 | B<1 | A<2 + B<2` => (`A + B` => (A++ >> B++) >|> `A<1 + B>1` => A += 2 >|> B++)")]
+        public void ItemEqualsTest(string effect)
+        {
+            LogicManagerBuilder lmb = new();
+            lmb.GetOrAddTerm("A");
+            lmb.GetOrAddTerm("B");
+
+            LogicManager lm = new(lmb);
+
+            LogicItem i1 = lm.FromItemString("I", effect);
+            LogicItem i2 = lm.FromItemString("I", effect);
+
+            i1.Should().Be(i2);
+            i1.GetHashCode().Should().Be(i2.GetHashCode());
+        }
+
+    }
+}