Cleanups #103
Merged
Cleanups #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will make it easier and safer to add new types (e.g. date and enum).
…h manually. This will make it easier and safer to add new values (e.g. date and enum).
…spath manually. This will make it easier and safer to add new values (e.g. date and enum).
… reduce the number of arguments passes, and name them. Also attaching functionality to the context for added convenience.
…lue rather than doing explicit type dispath manually. This will make it easier and safer to add new values (e.g. date and enum).
|
Included is #85. |
alexandrinaw
approved these changes
Apr 18, 2018
| return []*Worksheet{childWs} | ||
| } | ||
| if _, ok := value.(*Slice); ok { | ||
| panic("slices-of-slices are not supported yet") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces three functions on
Value(and one onType), to leverage go’s dynamic dispatch rather than rely on type switches. This will make it more natural to introduce adateandenumtype, and will make the changes much more go compiler directed, vs relying on code inspection to feel confident the implementation is correct.There are more spots where we do type dispatch, and special handling, but they are mostly ref vs not-ref related, and would matter when we introduce a
map[x]ytype.Each commit in this PR is isolated, and meant to be reviewed by itself.