Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with GitHub Actions #1542

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

NorthernMan54
Copy link
Contributor

@NorthernMan54 NorthernMan54 commented Sep 19, 2023

♻️ Current situation

Github Actions fail with Error: Bad response: 422 {"message":"Can't add a job to a build that is already closed. Build 6224987022 is closed. See docs.coveralls.io/parallel-builds","error":true}

Node 20 builds are failing
Windows builds are failing

💡 Proposed solution

Temporarily removed Node 20 builds from the GitHub actions
Corrected location of nssm to resolve Windows builds
And turned off coveralls coverage reporting

⚙️ Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

@NorthernMan54 NorthernMan54 changed the title Northern man54 patch 1 Fix issues with GitHub Actions Sep 19, 2023
Copy link
Contributor

@bwp91 bwp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i’m happy if you’re happy! all checks seem to be passing so 🚀

@NorthernMan54 NorthernMan54 reopened this Sep 19, 2023
@NorthernMan54 NorthernMan54 merged commit e2ed5fc into beta-4.50.6 Sep 19, 2023
37 of 39 checks passed
@NorthernMan54 NorthernMan54 deleted the NorthernMan54-patch-1 branch September 19, 2023 17:32
@NorthernMan54
Copy link
Contributor Author

Getting the checks working was my goal !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants