Skip to content

Commit

Permalink
try some changes
Browse files Browse the repository at this point in the history
  • Loading branch information
bwp91 committed Nov 8, 2023
1 parent 935176d commit ed31fef
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ <h4 class="card-title mb-0">
<a href="javascript:void(0)" class="card-link grey-text" aria-label="Plugin actions drop down menu"
ngbDropdownToggle>
<span class="card-link">
<i class="fas fa-wrench"></i>
<i class="fas fa-ellipsis-v pl-1"></i>
</span>
</a>
<div ngbDropdownMenu aria-labelledby="Plugin actions drop down menu">
Expand Down Expand Up @@ -136,13 +136,13 @@ <h4 class="card-title mb-0">
(click)="$plugin.uninstallPlugin(plugin)">
<i class="fas fa-fw fa-trash"></i> {{ 'plugins.button_uninstall' | translate }}
</button>
<div class="dropdown-divider"></div>
<a ngbDropdownItem target="_blank" rel="noopener noreferrer" class="text-decoration-none"
*ngIf="plugin.links.homepage || plugin.links.npm" [href]="plugin.links.homepage || plugin.links.npm">
<i class="{{ plugin.links?.homepage?.includes('github.com') ? 'fa fa-lg fa-github' : 'fas fa-external-link-alt' }}"></i> Plugin Homepage

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
github.com
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
</a>
</div>
</span>
<a class="card-link grey-text ml-3" target="_blank" rel="noopener noreferrer" aria-label="Plugin homepage"
*ngIf="plugin.links.homepage || plugin.links.npm" [href]="plugin.links.homepage || plugin.links.npm"
[ngbTooltip]="plugin.links.homepage || plugin.links.npm" placement="left" container="body" openDelay="150">
<i class="fas fa-external-link-alt"></i>
</a>
</div>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,20 @@
<br>
<span class="grey-text">
<span *ngIf="homebridgePkg.installedVersion && !homebridgePkg.updateAvailable && !homebridgePkg.betaUpdateAvailable"
[translate]="'status.homebridge.label_up_to_date'">
Up To Date
[translate]="'status.homebridge.label_up_to_date'">
Up To Date
</span>
<a href="javascript:void(0)" (click)="$plugin.upgradeHomebridge(homebridgePkg)" class="primary-text"
*ngIf="homebridgePkg.installedVersion && homebridgePkg.updateAvailable && !homebridgePkg.betaUpdateAvailable"
[translate]="'status.homebridge.label_update_available'" [translateParams]="homebridgePkg"
ngbTooltip="{{'plugins.button_upgrade' | translate}} Homebridge">
Update Available
*ngIf="homebridgePkg.installedVersion && homebridgePkg.updateAvailable && !homebridgePkg.betaUpdateAvailable"
[translate]="'status.homebridge.label_update_available'" [translateParams]="homebridgePkg"
ngbTooltip="{{'plugins.button_upgrade' | translate}} Homebridge">
Update Available
</a>
<a href="javascript:void(0)" (click)="$plugin.upgradeHomebridge(homebridgePkg, 'beta')" class="primary-text"
*ngIf="homebridgePkg.installedVersion && !homebridgePkg.updateAvailable && homebridgePkg.betaUpdateAvailable"
[translate]="'status.homebridge.label_update_available'" [translateParams]="homebridgePkg"
ngbTooltip="{{'plugins.button_upgrade' | translate}} Homebridge">
Update Available
*ngIf="homebridgePkg.installedVersion && !homebridgePkg.updateAvailable && homebridgePkg.betaUpdateAvailable"
[translate]="'status.homebridge.label_update_available'" [translateParams]="homebridgePkg"
ngbTooltip="{{'plugins.button_upgrade' | translate}} Homebridge">
Update Available
</a>
</span>
</div>
Expand All @@ -77,7 +77,7 @@
<div class="hb-status-item d-flex flex-row mr-4 pr-4">
<div class="d-flex">
<div class="mb-0 px-3 py-2 hb-status-icon">
<i class="fas fa-exclamation-circle primary-text" *ngIf="homebridgePluginStatus.length"></i>
<i class="fas fa-cloud-upload-alt primary-text" *ngIf="homebridgePluginStatus.length"></i>
<i class="fas fa-check-circle primary-text" *ngIf="!homebridgePluginStatus.length"></i>
</div>
<div class="align-self-center">
Expand All @@ -94,6 +94,5 @@
</div>
</div>
</div>

</div>
</div>
4 changes: 2 additions & 2 deletions ui/src/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@
"status.network.label_received_per_second": "Received",
"status.network.label_sent_per_second": "Sent",
"status.network.title_network": "Network Activity",
"status.plugin_out_of_date": "Plugin Out of Date",
"status.plugins_out_of_date": "Plugins Out of Date",
"status.plugin_out_of_date": "Update Available",
"status.plugins_out_of_date": "Updates Available",
"status.services.label_not_running": "Not running",
"status.services.label_running": "Running",
"status.services.label_running_on_port": "Port: {{port}}",
Expand Down

0 comments on commit ed31fef

Please sign in to comment.