Other Changes

- improve github actions - removed force of earlier version of `bonjour-service`` as a fix has been implemented in latest version - updated release drafter template so releases do not start with a `v` h
homebridge · Jan 8, 2024 · 3405e03 · 3405e03
1 parent fd926f7
commit 3405e03
Show file tree

Hide file tree

Showing 8 changed files with 176 additions and 195 deletions.
diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml
@@ -0,0 +1,34 @@
+name-template: '$RESOLVED_VERSION'
+tag-template: '$RESOLVED_VERSION'
+
+categories:
+  - title: 'Breaking Changes'
+    labels:
+      - 'breaking change'
+  - title: 'Featured Changes'
+    labels:
+      - 'feature'
+      - 'enhancement'
+  - title: 'Bug Fixes'
+    labels:
+      - 'fix'
+      - 'bugfix'
+      - 'bug'
+  - title: 'Other Changes'
+    labels:
+      - 'documentation'
+
+autolabeler:
+  - label: 'fix'
+    branch:
+      - '/fix\/.+/'
+    title:
+      - '/fix/i'
+  - label: 'feature'
+    branch:
+      - '/feature\/.+/'
+
+change-template: '- $TITLE @$AUTHOR [#$NUMBER]'
+template: |
+  ## Other Changes
+  $CHANGES
diff --git a/.github/workflows/Attach Artifacts.yml b/.github/workflows/Attach Artifacts.yml
@@ -25,7 +25,7 @@ jobs:
       # Sanity check to ensure that release tags don't start with a 'v' version prefix but adhere to the X.Y.Z format
       - name: Check for Tag name Format ${{ github.event.inputs.tag }}
         # https://github.com/orgs/community/discussions/25017
-        if: startsWith(github.event.inputs.tag, 'v') && github.event_name == 'workflow_dispatch'
+        if: startsWith(github.event.inputs.tag, 'v')
         run: |
           echo "Release Tag name must not start with 'v', this was supplied ${{ github.event.inputs.tag }}"
           exit 1
@@ -59,7 +59,7 @@ jobs:
         if: github.event_name == 'workflow_dispatch'
         uses: actions/upload-artifact@v4
         with:
-          name: 'homebridge-config-ui-x-${{ github.event.inputs.tag }}(github.event.inputs.tag).tar.gz'
+          name: 'homebridge-config-ui-x-${{ github.event.inputs.tag }}.tar.gz'
           path: |
             ./homebridge-config-ui-x-${{ github.event.inputs.tag }}.tar.gz
       
@@ -68,7 +68,7 @@ jobs:
         if: github.event_name == 'workflow_dispatch'
         uses: actions/upload-artifact@v4
         with:
-          name: 'SHASUMS256(github.event.inputs.tag).txt'
+          name: 'SHASUMS256.txt'
           path: |
             ./SHASUMS256.txt
 
@@ -84,54 +84,54 @@ jobs:
       - name: Get version from ${{ github.event_name }} tag
         if: github.event_name == 'release'
         id: get_version
-        uses: nowsprinting/check-version-format-action@v3
+        uses: jannemattila/get-version-from-tag@v3
 
-      - name: Install package ${{ steps.get_version.outputs.full }}
+      - name: Install package ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         run: |
           export npm_config_prefix=$(pwd)/package
-          npm install -g homebridge-config-ui-x@${{ steps.get_version.outputs.full }}
+          npm install -g homebridge-config-ui-x@${{ steps.get_version.outputs.version }}
 
-      - name: Remove invalid node-pty node-gyp run ${{ steps.get_version.outputs.full }}
+      - name: Remove invalid node-pty node-gyp run ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         run: |
           rm -rf $(pwd)/package/lib/node_modules/homebridge-config-ui-x/node_modules/@homebridge/node-pty-prebuilt-multiarch/build
 
-      - name: Create Bundle ${{ steps.get_version.outputs.full }}
+      - name: Create Bundle ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         run: |
-          tar -C $(pwd)/package --owner=0 --group=0 --format=posix -czvf homebridge-config-ui-x-${{ steps.get_version.outputs.full }}.tar.gz .
-          shasum -a 256 homebridge-config-ui-x-${{ steps.get_version.outputs.full }}.tar.gz > SHASUMS256.txt
+          tar -C $(pwd)/package --owner=0 --group=0 --format=posix -czvf homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz .
+          shasum -a 256 homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz > SHASUMS256.txt
 
-      - name: Check Bundle ${{ steps.get_version.outputs.full }}
+      - name: Check Bundle ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         run: |
-          if [ $(stat -c%s "homebridge-config-ui-x-${{ steps.get_version.outputs.full }}.tar.gz") -lt 10000000 ]; then
+          if [ $(stat -c%s "homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz") -lt 10000000 ]; then
             echo "Bundle is under 10MB, stopping"
             exit 1
           fi
     
-      - name: Upload tar.gz Bundle to GitHub Artifacts ${{ steps.get_version.outputs.full }}
+      - name: Upload tar.gz Bundle to GitHub Artifacts ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         uses: actions/upload-artifact@v4
         with:
-          name: 'homebridge-config-ui-x-${{ steps.get_version.outputs.full }}.tar.gz'
+          name: 'homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz'
           path: |
-            ./homebridge-config-ui-x-${{ steps.get_version.outputs.full }}.tar.gz
+            ./homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz
       
 
-      - name: Upload SHASUMS256.txt to GitHub Artifacts ${{ steps.get_version.outputs.full }}
+      - name: Upload SHASUMS256.txt to GitHub Artifacts ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         uses: actions/upload-artifact@v4
         with:
           name: 'SHASUMS256.txt'
           path: |
             ./SHASUMS256.txt
 
-      - name: Attach Bundle ${{ steps.get_version.outputs.full }}
+      - name: Attach Bundle ${{ steps.get_version.outputs.version }}
         if: github.event_name == 'release'
         uses: AButler/[email protected]
         with:
-          files: 'homebridge-config-ui-x-${{ steps.get_version.outputs.full }}.tar.gz;SHASUMS256.txt'
+          files: 'homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz;SHASUMS256.txt'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          release-tag: ${{ steps.get_version.outputs.full }}
+          release-tag: ${{ steps.get_version.outputs.version }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Get Release Tag
         id: get_version
-        uses: jannemattila/get-version-from-tag@v1
+        uses: jannemattila/get-version-from-tag@v3
       - name: Tag Info
         run: |
           echo "Release Tag: ${{github.ref}}"
@@ -57,45 +57,45 @@ jobs:
         with:
           node-version: 20.x
 
-      - name: Tag
-        id: tag
-        uses: JinoArch/get-latest-tag@latest
+      - name: Get Release Tag
+        id: get_version
+        uses: jannemattila/get-version-from-tag@v3
 
     # Sanity check to ensure that release tags don't start with a 'v' version prefix but adhere to the X.Y.Z format
       - name: Check for Tag name Format
         # https://github.com/orgs/community/discussions/25017
-        if: startsWith(steps.tag.outputs.latestTag, 'v')
+        if: startsWith(steps.get_version.outputs.version, 'v')
         run: |
-          echo "Release Tag name must not start with 'v', this was supplied ${{steps.tag.outputs.latestTag}}"
+          echo "Release Tag name must not start with 'v', this was supplied ${{steps.get_version.outputs.version}}"
           exit 1
 
       - name: Install package
         run: |
           export npm_config_prefix=$(pwd)/package
-          npm install -g homebridge-config-ui-x@${{ steps.tag.outputs.latestTag }}
+          npm install -g homebridge-config-ui-x@${{ steps.get_version.outputs.version }}
 
       - name: Remove invalid node-pty node-gyp run
         run: |
           rm -rf $(pwd)/package/lib/node_modules/homebridge-config-ui-x/node_modules/@homebridge/node-pty-prebuilt-multiarch/build
 
       - name: Create Bundle
         run: |
-          tar -C $(pwd)/package --owner=0 --group=0 --format=posix -czvf homebridge-config-ui-x-${{ steps.tag.outputs.latestTag }}.tar.gz .
-          shasum -a 256 homebridge-config-ui-x-${{ steps.tag.outputs.latestTag }}.tar.gz > SHASUMS256.txt
+          tar -C $(pwd)/package --owner=0 --group=0 --format=posix -czvf homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz .
+          shasum -a 256 homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz > SHASUMS256.txt
 
       - name: Check Bundle
         run: |
-          if [ $(stat -c%s "homebridge-config-ui-x-${{ steps.tag.outputs.latestTag }}.tar.gz") -lt 10000000 ]; then
+          if [ $(stat -c%s "homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz") -lt 10000000 ]; then
             echo "Bundle is under 10MB, stopping"
             exit 1
           fi
     
       - name: Upload tar.gz Bundle to GitHub Artifacts
         uses: actions/upload-artifact@v4
         with:
-          name: 'homebridge-config-ui-x-${{ steps.tag.outputs.latestTag }}.tar.gz'
+          name: 'homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz'
           path: |
-            ./homebridge-config-ui-x-${{ steps.tag.outputs.latestTag }}.tar.gz
+            ./homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz
       
 
       - name: Upload SHASUMS256.txt to GitHub Artifacts
@@ -108,6 +108,6 @@ jobs:
       - name: Attach Bundle
         uses: AButler/[email protected]
         with:
-          files: 'homebridge-config-ui-x-${{ steps.tag.outputs.latestTag }}.tar.gz;SHASUMS256.txt'
+          files: 'homebridge-config-ui-x-${{ steps.get_version.outputs.version }}.tar.gz;SHASUMS256.txt'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          release-tag: ${{ steps.tag.outputs.latestTag }}
+          release-tag: ${{ steps.get_version.outputs.version }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,11 +2,27 @@
 
 All notable changes to homebridge-config-ui-x will be documented in this file.
 
+## BETA (TBD)
+
+### UI Changes
+
+- 
+
+### Translation Changes
+
+- updates to uk.json language file (#1978) (#1979) (@xrust83)
+
+### Other Changes
+
+- improve github actions
+- removed force of earlier version of `bonjour-service`` as a fix has been implemented in latest version 
+- updated release drafter template so releases do not start with a `v`
+
 ## 4.55.1 (2024-01-07)
 
 ### Bug Fixes
 
-- Force earlier version of bonjour-service to resolve [#1973](https://github.com/homebridge/homebridge-config-ui-x/issues/1973) and [#1975](https://github.com/homebridge/homebridge-config-ui-x/issues/1975)
+- Force earlier version of `bonjour-service` to resolve [#1973](https://github.com/homebridge/homebridge-config-ui-x/issues/1973) and [#1975](https://github.com/homebridge/homebridge-config-ui-x/issues/1975)
   - **If you experienced this issue, we would recommened you go into Homebridge Setting and turn off Homebridge 'Insecure' Mode (Enable Accessory Control) before upgrading**, after you upgrade you can renable.
 
 ### Translation Changes