fix: EventEmitter memory leak warnings when you have a significant nu…

…mber of child bridges. (#2087)
homebridge · Jul 4, 2024 · 00705fb · 00705fb
1 parent 07720e8
commit 00705fb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/core/homebridge-ipc/homebridge-ipc.service.ts b/src/core/homebridge-ipc/homebridge-ipc.service.ts
@@ -28,6 +28,8 @@ export class HomebridgeIpcService extends EventEmitter {
   public setHomebridgeProcess(process: ChildProcess) {
     this.homebridge = process;
 
+    this.homebridge.setMaxListeners(this.homebridge.getMaxListeners() + 2);
+
     this.homebridge.on('message', (message: { id: string; data: unknown }) => {
       if (typeof message !== 'object' || !message.id) {
         return;
@@ -57,14 +59,17 @@ export class HomebridgeIpcService extends EventEmitter {
       const actionTimeout = setTimeout(() => {
         // eslint-disable-next-line @typescript-eslint/no-use-before-define
         this.removeListener(responseEvent, listener);
+        this.setMaxListeners(this.getMaxListeners() - 1);
         reject('The Homebridge service did not respond');
       }, 3000);
 
       const listener = (data: any) => {
         clearTimeout(actionTimeout);
+        this.setMaxListeners(this.getMaxListeners() - 1);
         resolve(data);
       };
 
+      this.setMaxListeners(this.getMaxListeners() + 1);
       this.once(responseEvent, listener);
       this.sendMessage(requestEvent);
     });

diff --git a/src/modules/child-bridges/child-bridges.service.ts b/src/modules/child-bridges/child-bridges.service.ts
@@ -38,15 +38,19 @@ export class ChildBridgesService {
       client.emit('child-bridge-status-update', data);
     };
 
+    this.homebridgeIpcService.setMaxListeners(this.homebridgeIpcService.getMaxListeners() + 1);
     this.homebridgeIpcService.on('childBridgeStatusUpdate', listener);
 
     // cleanup on disconnect
     const onEnd = () => {
       client.removeAllListeners('end');
       client.removeAllListeners('disconnect');
+      client.setMaxListeners(client.getMaxListeners() - 2);
       this.homebridgeIpcService.removeListener('childBridgeStatusUpdate', listener);
+      this.homebridgeIpcService.setMaxListeners(this.homebridgeIpcService.getMaxListeners() - 1);
     };
 
+    client.setMaxListeners(client.getMaxListeners() + 2);
     client.on('end', onEnd.bind(this));
     client.on('disconnect', onEnd.bind(this));
   }