Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest <- beta #1027

Merged
merged 9 commits into from
Apr 16, 2024
Merged

latest <- beta #1027

merged 9 commits into from
Apr 16, 2024

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Apr 10, 2024 •
edited
Loading

feel free to not review the /docs folder 😆

Changed

  • Create CHANGELOG.md file
  • Fix typos + add logo to README.md
  • Refresh package-lock.json (no major changes to dep versions)
  • general repo updates
  • add alpha releases
  • dependency updates
  • fix typedoc generation
  • update homebridge dependencies
  • regenerate docs

@bwp91 bwp91 requested a review from Supereg April 10, 2024 21:06
@bwp91
Copy link
Contributor Author

bwp91 commented Apr 16, 2024

@Supereg would you be happy with a 0.12.0 release of hap-nodejs soon?

Supereg
Supereg approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and regeneration of the docs 👍

src/lib/Accessory.ts
Comment on lines +1187 to +1194
* - `info.username` - formatted as a MAC address, like `CC:22:3D:E3:CE:F6`, of this accessory.
* Must be globally unique from all Accessories on your local network.
* - `info.pincode` - the 8-digit pin code for clients to use when pairing this Accessory.
* Must be formatted as a string like `031-45-154`.
* - `info.category` - one of the values of the `Accessory.Category` enum, like `Accessory.Category.SWITCH`.
* This is a hint to iOS clients about what "type" of Accessory this represents, so
* that for instance an appropriate icon can be drawn for the user while adding a
* new Accessory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improve documentation here 🚀

@Supereg
Copy link
Member

Supereg commented Apr 16, 2024

would you be happy with a 0.12.0 release of hap-nodejs soon?

@bwp91 how about we finally tag a 1.0.0 release. I caught myself endlessly waiting for the "perfect time" to tag that. But honestly I think we should just tag that now (also given that we are cutting support for older nodejs versions with this release). Having a 1.0.0 without massive changes is also great to ensure a lot of people can adopt that without encountering tons of issues.
And then we can finally embrace proper semver semantics and introduce follow-up changes step by step. Or are there any major changes you want to see before that? Or things you want to break with 1.0?

@bwp91
Copy link
Contributor Author

bwp91 commented Apr 16, 2024

I'm happy to along with any versioning that you suggest. Agreed that with a 1.0.0 we can take the opportunity to really specify that the officially supported node versions are 18 and 20.

I'm not actually sure whether it would still run on e.g. node 16.

@bwp91
Copy link
Contributor Author

bwp91 commented Apr 16, 2024

Or are there any major changes you want to see before that? Or things you want to break with 1.0?

Nothing from me. My main focus here is to get a version of hap-nodejs published with updated dependencies, then work my way through homebridge itself and the UI with updated hap-nodejs

@bwp91 bwp91 merged commit 8d7fe93 into latest Apr 16, 2024
16 checks passed
@bwp91 bwp91 deleted the beta-0.11.3 branch April 16, 2024 18:25
@bwp91
Copy link
Contributor Author

bwp91 commented Apr 16, 2024

i merged into latest branch, maybe i will await further instruction on release version!

@Supereg
Copy link
Member

Supereg commented Apr 17, 2024

Tagging a 1.0 sounds good to me 👍

Nothing from me. My main focus here is to get a version of hap-nodejs published with updated dependencies, then work my way through homebridge itself and the UI with updated hap-nodejs

Thanks for the hard work there 🚀

@hjdhjd
Copy link
Contributor

hjdhjd commented Apr 17, 2024

Not with a memory leak still hanging out there…@Supereg, I’d suggest holding off for a bit there.

@bwp91
Copy link
Contributor Author

bwp91 commented Apr 17, 2024

@hjdhjd happy with a 0.12.0 release until memory leak is fixed and then bumping to 1.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Supereg Supereg Supereg approved these changes

Assignees
No one assigned
Labels
latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwp91 @Supereg @hjdhjd