fix: Ensure data is only transmitted on open and ready connections.

homebridge · Jul 4, 2024 · 87c9077 · 87c9077
1 parent 853171f
commit 87c9077
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/lib/camera/RecordingManagement.ts b/src/lib/camera/RecordingManagement.ts
@@ -1018,6 +1018,10 @@ class CameraRecordingStream extends EventEmitter implements DataStreamProtocolHa
  let offset = 0;
  let dataChunkSequenceNumber = 1;
  while (offset < fragment.length) {
+ if (this.closed) {
+ break;
+ }
+
  const data = fragment.slice(offset, offset + maxChunk);
  offset += data.length;
 

diff --git a/src/lib/datastream/DataStreamServer.ts b/src/lib/datastream/DataStreamServer.ts
@@ -715,7 +715,9 @@ export class DataStreamConnection extends EventEmitter {
  header.protocol = protocol;
  header.event = event;
 
- this.sendHDSFrame(header, message);
+ if (this.state === ConnectionState.READY) {
+ this.sendHDSFrame(header, message);
+ }
  }
 
  /**