Skip to content

Commit

Permalink
Merge branch 'latest' into beta-0.12.3
Browse files Browse the repository at this point in the history
  • Loading branch information
donavanbecker committed Jun 24, 2024
2 parents e74efd9 + 853171f commit 4a8cea0
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions src/lib/camera/RecordingManagement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ export class RecordingManagement {
// eslint-disable-next-line @typescript-eslint/no-use-before-define
this.recordingStream = new CameraRecordingStream(connection, this.delegate, id, streamId);
this.recordingStream.on(CameraRecordingStreamEvents.CLOSED, () => {
debug("[HDS %s] Removing active recoding session from recording management!");
debug("[HDS %s] Removing active recoding session from recording management!", connection.remoteAddress);
this.recordingStream = undefined;
});

Expand Down Expand Up @@ -1056,8 +1056,8 @@ class CameraRecordingStream extends EventEmitter implements DataStreamProtocolHa

if (!lastFragmentWasMarkedLast && !this.closed) {
// Delegate violates the contract. Exited normally on a non-closed stream without properly setting `isLast`.
console.warn(`[HDS ${this.connection.remoteAddress}] Delegate finished streaming for ${this.streamId} without setting RecordingPacket.isLast. \
Can't notify Controller about endOfStream!`);
console.warn(`[HDS ${this.connection.remoteAddress}] Delegate finished streaming for ${this.streamId} without setting RecordingPacket.isLast. ` +
"Can't notify Controller about endOfStream!");
}
} catch (error) {
if (this.closed) {
Expand Down Expand Up @@ -1095,11 +1095,6 @@ class CameraRecordingStream extends EventEmitter implements DataStreamProtocolHa
}
}

if (initialization) { // we never actually sent anything out there!
console.warn(`[HDS ${this.connection.remoteAddress}] Delegate finished recording stream ${this.streamId} without sending anything out. \
Controller will CANCEL.`);
}

debug("[HDS %s] Finished DATA_SEND transmission for stream %d!", this.connection.remoteAddress, this.streamId);
}

Expand Down

0 comments on commit 4a8cea0

Please sign in to comment.