chore(aws): Update to aws-iot-device-sdk-v2 to fix AWS authentication issues #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Teagan42 I had to revert this in the end, I was getting a lot of build issues with some I managed to get the plugin to install eventually (on my pi I had to I liked what you did in the PR, the changes make sense, but it's just all the extra bloat that seems to come with switching to the aws iot v2 library :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to get AWS working again in homebridge-ultimate-gove by implementing the new version of the aws library. I did this fairly quickly and didn't have the time to test it before it got late in the evening.
Should Fix #677 #676 #678