Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NDEF from nfc formats. Workaround to deploy to appstore #2495

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 27, 2023

Summary

Distribute pipeline is failing for iOS since the drop support to older iOS versions were merged with error The sdk version '17.0' and min OS version '15.0' are not compatible for the entitlement 'com.apple.developer.nfc.readersession.formats' because 'NDEF is disallowed

I found several mentions from other developers about this bug from Apple since iOS 13 and the workaround is to simply remove NDEF from nfc formats, even doing that the reading and writting tags keeps working fine.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest December 27, 2023 18:01
@bgoncal bgoncal self-assigned this Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 153 lines in your changes are missing coverage. Please review.

Comparison is base (63c21ad) 28.19% compared to head (0d6c77a) 28.57%.
Report is 1 commits behind head on master.

Files Patch % Lines
Sources/App/Settings/NFC/iOSTagManager.swift 0.00% 28 Missing ⚠️
Sources/App/WebView/IncomingURLHandler.swift 0.00% 19 Missing ⚠️
...s/Shared/Common/SiriIntents+ConvenienceInits.swift 0.00% 10 Missing ⚠️
Sources/App/Settings/ActionConfigurator.swift 0.00% 6 Missing ⚠️
...ources/App/Settings/Eureka/SettingsButtonRow.swift 0.00% 6 Missing ⚠️
Sources/Shared/API/Models/RealmZone.swift 58.33% 5 Missing ⚠️
Sources/App/Scenes/SceneManager.swift 20.00% 4 Missing ⚠️
Sources/App/Scenes/SettingsSceneDelegate.swift 0.00% 4 Missing ⚠️
...tings/Connection/ConnectionURLViewController.swift 0.00% 4 Missing ⚠️
...es/App/Settings/SettingsDetailViewController.swift 0.00% 4 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
+ Coverage   28.19%   28.57%   +0.37%     
==========================================
  Files         286      286              
  Lines       30789    30308     -481     
==========================================
- Hits         8682     8661      -21     
+ Misses      22107    21647     -460     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 2a69feb into master Jan 3, 2024
8 checks passed
@bgoncal bgoncal deleted the fix-distribute-nfc-error branch January 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants