Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarPlay Actions first iteration #2489

Closed
wants to merge 2 commits into from
Closed

CarPlay Actions first iteration #2489

wants to merge 2 commits into from

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 22, 2023

Summary

Aiming to keep CarPlay app simple and direct to the point, in this first iteration I added the Action configured in companion App to be available also in CarPlay

Screenshots

Screenshot 2023-12-22 at 01 10 04

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest December 22, 2023 00:13
@bgoncal bgoncal self-assigned this Dec 22, 2023
@bgoncal bgoncal mentioned this pull request Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 260 lines in your changes are missing coverage. Please review.

Comparison is base (63c21ad) 28.19% compared to head (922ecf7) 28.49%.
Report is 1 commits behind head on master.

Files Patch % Lines
Sources/App/CarPlay/CPFavoriteActionsSection.swift 0.00% 77 Missing ⚠️
Sources/App/Settings/NFC/iOSTagManager.swift 0.00% 28 Missing ⚠️
Sources/App/Scenes/CarPlaySceneDelegate.swift 0.00% 27 Missing ⚠️
Sources/App/WebView/IncomingURLHandler.swift 0.00% 19 Missing ⚠️
...s/Shared/Common/SiriIntents+ConvenienceInits.swift 0.00% 10 Missing ⚠️
Sources/App/Settings/ActionConfigurator.swift 0.00% 6 Missing ⚠️
...ources/App/Settings/Eureka/SettingsButtonRow.swift 0.00% 6 Missing ⚠️
Sources/Shared/API/Models/RealmZone.swift 58.33% 5 Missing ⚠️
Sources/App/Scenes/SceneManager.swift 20.00% 4 Missing ⚠️
Sources/App/Scenes/SettingsSceneDelegate.swift 0.00% 4 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2489      +/-   ##
==========================================
+ Coverage   28.19%   28.49%   +0.29%     
==========================================
  Files         286      288       +2     
  Lines       30789    30423     -366     
==========================================
- Hits         8682     8669      -13     
+ Misses      22107    21754     -353     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jb123567
Copy link

@bgoncal this looks amazing, when will this be ready to test?

@bgoncal
Copy link
Member Author

bgoncal commented Dec 27, 2023

@bgoncal this looks amazing, when will this be ready to test?

As soon as this PR get merged it will be available in testflight. For now I'm waiting on @zacwest review

@bgoncal bgoncal marked this pull request as draft December 28, 2023 13:18
@bgoncal
Copy link
Member Author

bgoncal commented Dec 28, 2023

Converted to draft to put this PR on hold while we wait for #2320

@bgoncal bgoncal closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants