Clone app-header-layout #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone
app-header-layoutto a fix upstream bug PolymerElements/app-layout#486app-header-layoutuses z-index on content which creates a separate stacking content causing dropdown menus to be hidden behind the header.My previous hack applied
transform: translate(0)on content causing childposition: fixedelements to behave likeposition: absolute.However in that case such elements are scrolled together with content. This is OK for dropdown menus, but is bad for FAB.
The solution proposed here: https://stackoverflow.com/a/37682798/4755809 is to have two wrapper divs. The outer one is non-static and is the base for
position: absolutelocation, and the inner one is static andoverflow: auto.