-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CAP_CHECKPOINT_RESTORE privileges #2455
base: master
Are you sure you want to change the base?
Add support for CAP_CHECKPOINT_RESTORE privileges #2455
Conversation
📝 WalkthroughWalkthroughThe changes involve updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AddOn
participant Configuration
User->>Configuration: Request configuration options
Configuration-->>User: Provide current options
User->>AddOn: Configure with CHECKPOINT_RESTORE
AddOn->>Configuration: Validate configuration
Configuration-->>AddOn: Confirm valid configuration
AddOn-->>User: Configuration successful
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/add-ons/configuration.md (1)
158-158
: Fix table formatting: Add trailing pipeThe table row is missing a trailing pipe character, which should be consistent with the table's style.
Apply this change:
-| `privileged` | list | | Privilege for access to hardware/system. Available access: `BPF`, `CHECKPOINT_RESTORE`, `DAC_READ_SEARCH`, `IPC_LOCK`, `NET_ADMIN`, `NET_RAW`, `PERFMON`, `SYS_ADMIN`, `SYS_MODULE`, `SYS_NICE`, `SYS_PTRACE`, `SYS_RAWIO`, `SYS_RESOURCE` or `SYS_TIME`. +| `privileged` | list | | Privilege for access to hardware/system. Available access: `BPF`, `CHECKPOINT_RESTORE`, `DAC_READ_SEARCH`, `IPC_LOCK`, `NET_ADMIN`, `NET_RAW`, `PERFMON`, `SYS_ADMIN`, `SYS_MODULE`, `SYS_NICE`, `SYS_PTRACE`, `SYS_RAWIO`, `SYS_RESOURCE` or `SYS_TIME`. |🧰 Tools
🪛 Markdownlint
158-158: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style(MD055, table-pipe-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
docs/add-ons/configuration.md
(1 hunks)
🧰 Additional context used
🪛 Markdownlint
docs/add-ons/configuration.md
158-158: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style
(MD055, table-pipe-style)
🔇 Additional comments (1)
docs/add-ons/configuration.md (1)
158-158
: LGTM: Addition of CHECKPOINT_RESTORE privilege
The addition of CHECKPOINT_RESTORE
to the privileged capabilities list is well-documented and aligns with the PR objectives. This capability allows processes to use checkpoint/restore features, which can be useful for add-ons that need to save and restore process state.
🧰 Tools
🪛 Markdownlint
158-158: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style
(MD055, table-pipe-style)
Proposed change
Type of change
Additional information
Summary by CodeRabbit
CHECKPOINT_RESTORE
as a new access privilege in theprivileged
key.