-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit dlms cosem sub dependency to MIT version #122577
Conversation
Can you maybe trying to include cosem with the BSL version to see if the audit licenses script catches it? |
Not sure how i would do that. It is a sub dependency of a package i dont control. |
Just replace the dsmr parser dependency with the cosem one. The code doesn't work, but then at least the dependency is checked in the CI |
Like if the audit fails, we dont have to include this constraint |
That would not be a valid test since it would be a direct dependency instead of indirect. |
Pip licenses fetches all the packages installed on the system, so theoretically if you would bump the library to that version it should catch it. So what I'm trying to say, both direct and indirect dependencies are checked by the audit licenses check. But since the license of cosem is proprietary/other(MIT), I'm curious what it will do and if this PR is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have license checks in place, we should not be able to upgrade to a release that violates.
So, I don't think we need to pin this on our end?
../Frenck
Looks like the license audit catches it. So closing. |
Proposed change
Make sure we don't accidentally upgrade a the dsrm_parser library containing a reference to a sub project with a incompatible license.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: