Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSMR Slimme Meter integration relies on non-Open Source Python module #122576

Closed
EdwardBetts opened this issue Jul 25, 2024 · 6 comments
Closed
Assignees

Comments

@EdwardBetts
Copy link

EdwardBetts commented Jul 25, 2024

The DSMR Slimme Meter integration employs the dsmr-parser module, which in turn depends on dlms-cosem. The latter is distributed under the Business Source License 1.1, a license not recognized as open source. Consequently, this integration should be suspended until the proprietary component can be substituted with an open-source alternative.

See https://github.com/u9n/dlms-cosem and https://github.com/u9n/dlms-cosem/blob/master/LICENSE

Integration causing the issue

DSMR Slimme Meter

Link to integration documentation on our website

https://www.home-assistant.io/integrations/dsmr/

@home-assistant
Copy link

Hey there @RobBie1221, @frenck, mind taking a look at this issue as it has been labeled with an integration (dsmr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dsmr can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign dsmr Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


dsmr documentation
dsmr source
(message by IssueLinks)

@elupus
Copy link
Contributor

elupus commented Jul 25, 2024

At the moment it does not. It depends on dlms_cosem== 21.3.2 which is MIT licensed. But might be hard to track if it was upgraded.

@elupus
Copy link
Contributor

elupus commented Jul 25, 2024

Open upstream issue: ndokter/dsmr_parser#164

@elupus
Copy link
Contributor

elupus commented Jul 25, 2024

We should add a constraint on which version of dlms that can be used in HA.

@EdwardBetts
Copy link
Author

Sorry, my mistake. I didn't spot the dependency was versioned. We can probably close this bug.

@elupus
Copy link
Contributor

elupus commented Jul 25, 2024

The version is pinned before the incompatible license. And we catch it if it where to be upgraded, so closing.

@elupus elupus closed this as completed Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants