mobile_app_notification_cleared for wearos #4035
Conversation
|
I think for this PR we also need to make a manifest change to add the receiver to the`wear manifest like it is added for the main app manifest what issue are you running into with the emulator? edit: this PR will also need a docs update |
|
Ok, I have added the receiver to the manifest. The entire simulator just would crash as soon as the app started loading, I wasn't too worried because I have only just installed the wearos virtual device and I hoped someone else could test this change. |
|
have you also setup the notification service per the readme instructions from this repo? If you have then you dont really need to open the app, if you can login to the app it will register the device and create a service call....if you were able to login but cant keep the app open thats a known issue actually. For notifications the app just needs to be logged in to receive and send events but that all depends if you setup the firebase stuff otherwise notifications will not work in debug builds on the watch. |
|
I can't get logs because the whole simulator crashes and the logcat logs disappear to quickly. I haven't setup the notification service yet but the app won't even start anyway. |
There was a problem hiding this comment.
Tested the changes locally and it works as expected, the cleared event gets sent. Just need to move the method to common so the code can be completely shared. We also need to update the Wear OS companion docs to mention support is added in the beta version of the app.
wear/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt
Outdated
Show resolved
Hide resolved
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Looks good to me and tested it on my watch locally. Still needs docs update before we can merge. Please submit a PR to add a mention in the Wear OS docs.
We need to update this page: https://companion.home-assistant.io/docs/wear-os/#notifications
Summary
Moved the
NotificationDeleteRecieveto common and added it to the WearOS app.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1009
Any other notes
I have not been able to run the WearOS app at all on the simulator (even without any of my changes) so I haven't been able to test it but it compiles.