Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Z-Wave JS to 13.3.1 #3764

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Bump Z-Wave JS to 13.3.1 #3764

merged 1 commit into from
Sep 17, 2024

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Sep 17, 2024

Summary by CodeRabbit

  • New Features
    • Added support for Philio Technology Smart Keypad.
    • Introduced a new LED indication parameter for Inovelli NZW31 dimmer.
  • Bug Fixes
    • Corrected primary controller role identification for older controllers.
    • Resolved a critical call stack overflow issue with custom log transport.
    • Enhanced deserialization for additional WindowCoveringCC commands.
  • Version Updates
    • Updated Z-Wave JS component version to 13.3.1.
    • Incremented configuration file version to 0.7.2.

fixes: home-assistant/core#125843

Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

Walkthrough

The pull request introduces version 0.7.2 of the Z-Wave JS library, which includes bug fixes, configuration updates, and enhancements for device compatibility. Key changes involve correcting the primary controller role for older controllers, resolving a call stack overflow issue, and improving the deserialization process for WindowCoveringCC commands. Configuration files have been updated to support the Philio Technology Smart Keypad and include a new LED indication parameter for the Inovelli NZW31 dimmer. Additionally, the version numbers in related configuration files have been incremented to reflect these updates.

Changes

Files Change Summary
zwave_js/CHANGELOG.md Updated for version 0.7.2; includes bug fixes and configuration updates.
zwave_js/build.yaml Incremented ZWAVEJS_VERSION from 13.3.0 to 13.3.1.
zwave_js/config.yaml Updated version number from 0.7.1 to 0.7.2.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1bb2ba9 and 71486b1.

Files selected for processing (3)
  • zwave_js/CHANGELOG.md (2 hunks)
  • zwave_js/build.yaml (1 hunks)
  • zwave_js/config.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • zwave_js/config.yaml
Additional context used
Path-based instructions (2)
zwave_js/build.yaml (6)

Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

Pattern */**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"


Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.


Pattern */**(html|markdown|md): do not comment on HTML used for icons


Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

zwave_js/CHANGELOG.md (6)

Pattern */**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

Pattern */**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

Pattern */**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"


Pattern */**(html|markdown|md): - Use sentence-style capitalization also in headings.


Pattern */**(html|markdown|md): do not comment on HTML used for icons


Pattern */**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.

LanguageTool
zwave_js/CHANGELOG.md

[style] ~8-~8: Consider using a different verb for a more formal wording.
Context: ...on some older controllers

  • Z-Wave JS: Fixed an issue where passing a custom log tra...

(FIX_RESOLVE)

Additional comments not posted (4)
zwave_js/build.yaml (1)

13-13: Approve version bump with a request for more context.

Bumping the ZWAVEJS_VERSION to 13.3.1 looks good as it brings in the latest fixes and improvements.

However, could you please provide some context on what motivated this specific version bump and summarize any relevant changes or fixes in this version that are applicable to this project? Linking to the release notes would also be helpful for future reference and auditing.

zwave_js/CHANGELOG.md (3)

3-19: LGTM!

The changelog entry for version 0.7.2 looks good. The bug fixes, config file changes, and detailed changelog link are clear and consistent.

Tools
LanguageTool

[style] ~8-~8: Consider using a different verb for a more formal wording.
Context: ...on some older controllers

  • Z-Wave JS: Fixed an issue where passing a custom log tra...

(FIX_RESOLVE)


Line range hint 21-35: LGTM!

The changelog entry for version 0.7.1 looks good. The bug fixes, config file changes, and detailed changelog link are clear and consistent.

Tools
LanguageTool

[style] ~8-~8: Consider using a different verb for a more formal wording.
Context: ...on some older controllers

  • Z-Wave JS: Fixed an issue where passing a custom log tra...

(FIX_RESOLVE)


Line range hint 37-116: LGTM!

The changelog entry for version 0.7.0 looks good. The new features, bug fixes, config file changes, and detailed changelog links are all clear and consistent, even though the lists are quite long.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit 5aac803 into master Sep 17, 2024
10 checks passed
@frenck frenck deleted the bump-z-wave-js-13.3.1 branch September 17, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z-wave not responsing after update of today !
2 participants