add support for mijn.host DNS challenge #3749
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
Add support for mijn.host dns challenge |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes include the addition of support for the "mijn.host" DNS service in the Let's Encrypt project. This update encompasses modifications across multiple files, including the changelog, build configuration, and settings files. The updates introduce new variables, configuration options, and instructions to facilitate the integration of the new DNS provider, enhancing the overall functionality of the system. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
letsencrypt/config.yaml (1)
79-79: New Configuration Field ApprovedThe addition of the
mijn_host_api_keyfield is correctly implemented. It's crucial to ensure that documentation is updated to guide users on how to obtain and use this API key.
|
This needs a newer ACME version. Let's update Certbot first before adding more DNS challenge options. |
|
okay, I have raised PR in certbot repo, waiting for the maintainers to merge it. |
|
Maybe I was a bit unclear: mijn certbot plug-in requires ACME 2.11.0, but we ship with 2.7.4 currently: Maybe you could ask |
|
thanks, I saw you new PR where you upgrade the acme version |
|
by when can you merge this pr @agners |
|
@shubhamku044 with #3751 merged, you can now rebase/merge this PR and move forward. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
letsencrypt/config.yaml (1)
103-104: LGTM: New DNS providers added correctly.The addition of
dns-mijn-hostanddns-google-domainsto the provider list is correct and aligns with the PR objective. However, consider maintaining alphabetical order for better readability:dns-gandi|dns-gehirn|dns-godaddy|dns-google|dns-google-domains|\ dns-hetzner|dns-infomaniak|dns-joker|dns-linode|dns-luadns|dns-mijn-host|dns-namecheap|dns-netcup|dns-njalla|dns-nsone|\
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- letsencrypt/CHANGELOG.md (1 hunks)
- letsencrypt/build.yaml (1 hunks)
- letsencrypt/config.yaml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
letsencrypt/CHANGELOG.md (6)
Pattern
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
Pattern
*/**(html|markdown|md): do not comment on HTML used for icons
Pattern
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.letsencrypt/build.yaml (6)
Pattern
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
Pattern
*/**(html|markdown|md): do not comment on HTML used for icons
Pattern
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.letsencrypt/config.yaml (6)
Pattern
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
Pattern
*/**(html|markdown|md): do not comment on HTML used for icons
Pattern
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.
🔇 Additional comments (3)
letsencrypt/build.yaml (1)
27-27: LGTM! Verify consistency with PR objectives.The addition of
CERTBOT_DNS_MIJN_HOST_VERSION: 0.0.3is consistent with the existing structure and aligns with the PR objective of adding support for the mijn.host DNS challenge.To ensure this change is properly integrated, please run the following verification:
This script will help verify the proper integration of the mijn.host DNS challenge support and identify any potential conflicts or missing configurations.
letsencrypt/config.yaml (1)
77-77: LGTM: New API key field for mijn.host added correctly.The addition of the
mijn_host_api_keyfield is consistent with the PR objective and follows the existing pattern for DNS provider configurations.letsencrypt/CHANGELOG.md (1)
3-6: Changelog entry looks good.The new entry for version 5.2.1 is correctly formatted, follows the versioning convention, and clearly describes the added feature. It aligns well with the PR objectives of adding support for the mijn.host DNS challenge.
| @@ -99,8 +100,8 @@ schema: | |||
| propagation_seconds: int(60,3600)? | |||
| provider: "list(dns-azure|dns-cloudflare|dns-cloudns|dns-desec|\ | |||
| dns-digitalocean|dns-directadmin|dns-dnsimple|dns-dnsmadeeasy|\ | |||
| dns-duckdns|dns-dynu|dns-gehirn|dns-godaddy|dns-google|\ | |||
| dns-hetzner|dns-infomaniak|dns-joker|dns-linode|dns-luadns|dns-njalla|dns-nsone|\ | |||
| dns-duckdns|dns-dynu|dns-gehirn|dns-godaddy|dns-google|dns-google-domains|\ | |||
There was a problem hiding this comment.
That got dropped with #3750. This probably came in through a merge conflict:
| dns-duckdns|dns-dynu|dns-gehirn|dns-godaddy|dns-google|dns-google-domains|\ | |
| dns-duckdns|dns-dynu|dns-gehirn|dns-godaddy|dns-google|\ |
|
Hm, seems there is still a merge conflict: I guess the bump now bumped cryptography too high (to 43.0.1 🙈 ). Can the plug-in maybe loosen that restriction 🤔 |
|
sure, I will make the necessary changes |
|
FWIW, PR #3776 reverts Cryptography to 42 also for another reason, so you can rebase on this instead. |
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores